Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.5] Fix containerd fails to pull OCI image with non-http(s):// urls #6238

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

ktock
Copy link
Member

@ktock ktock commented Nov 12, 2021

Backporting #6221
Fixes #6220

Currently, containerd cannot pull OCI images that contain non-http(s):// urls.
This commit fixes this issue by allowing fallback when pull fails on a non-http(s):// url.

Signed-off-by: Kohei Tokunaga <[email protected]>
(cherry picked from commit 526defb)
Signed-off-by: Kohei Tokunaga <[email protected]>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 12, 2021

Build succeeded.

Copy link
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxpv mxpv merged commit 5fde9a5 into containerd:release/1.5 Nov 12, 2021
@ktock ktock deleted the urls-fallback-1.5 branch November 16, 2021 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants