-
-
Notifications
You must be signed in to change notification settings - Fork 304
Command changelog wip #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fbe26c9 to
5bf5542
Compare
b53e63b to
ad8d780
Compare
53c8237 to
99a1ae0
Compare
99a1ae0 to
e0a1b49
Compare
|
@Lee-W this is almost ready, I need to add more tests and fix the mypy errors, maybe you wanna run it. |
|
@woile I just test it. It looks great! It seems you miss the |
|
Sorry, I'm gonna remove the
What are the steps to reproduce this? |
Checkout this branch and run |
a7b3688 to
bfd814e
Compare
Codecov Report
@@ Coverage Diff @@
## command-changelog #163 +/- ##
====================================================
Coverage ? 91.55%
====================================================
Files ? 35
Lines ? 947
Branches ? 0
====================================================
Hits ? 867
Misses ? 80
Partials ? 0
Continue to review full report at Codecov.
|
033b26f to
dda193f
Compare
dda193f to
d3c4a3c
Compare
d3c4a3c to
84471b4
Compare
|
@Lee-W now is quite complete, I think it's ready to be merged into |
|
Is the default behavior now generate incremental changelog? I think this choice makes more sense. Just want to make sure everything works as you expect. |
|
Yes, for now I think it should be the default behavior, specially for existing projects with an old changelog. If issues araise we can always support some arguments in the bump's changelog somehow. |
TODO:
--changelogflag in bump command