Skip to content

Commit b0c6e4e

Browse files
committed
Incorporated changes suggested by CodeRabbit Bot
1 parent 650b88b commit b0c6e4e

File tree

6 files changed

+24
-21
lines changed

6 files changed

+24
-21
lines changed

rules/html/security/plaintext-http-link-html.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
id: plaintext-http-link-html
22
language: html
3-
severity: info
3+
severity: warning
44
message: >-
5-
This link points to a plaintext HTTP URL. Prefer an encrypted HTTPS URL
6-
if possible.
5+
"This link points to a plaintext HTTP URL. Prefer an encrypted HTTPS URL if possible."
76
note: >-
87
[CWE-319] Authentication Bypass by Primary Weakness
98
[REFERENCES]

rules/java/security/cbc-padding-oracle-java.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ note: >-
1313
rule:
1414
pattern: Cipher.getInstance($MODE)
1515
constraints:
16-
MODE:
17-
regex: '.*/CBC/PKCS5Padding'
16+
MODE:
17+
regex: ".*/CBC/PKCS5Padding"

rules/java/security/no-null-cipher-java.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,16 @@ id: no-null-cipher-java
22
severity: warning
33
language: java
44
message: >-
5-
NullCipher was detected. This will not encrypt anything; the cipher
6-
text will be the same as the plain text. Use a valid, secure cipher:
7-
Cipher.getInstance("AES/CBC/PKCS7PADDING"). See
8-
https://owasp.org/www-community/Using_the_Java_Cryptographic_Extensions
9-
for more information.
5+
NullCipher was detected. This will not encrypt anything; the cipher
6+
text will be the same as the plain text. Use a valid, secure cipher:
7+
Cipher.getInstance("AES/CBC/PKCS7PADDING"). See
8+
https://owasp.org/www-community/Using_the_Java_Cryptographic_Extensions
9+
for more information.
1010
note: >-
1111
[CWE-327] Use of a Broken or Risky Cryptographic Algorithm.
1212
[REFERENCES]
1313
- https://owasp.org/Top10/A02_2021-Cryptographic_Failures
1414
rule:
15-
any:
16-
- pattern: new NullCipher($$$)
17-
- pattern: new javax.crypto.NullCipher($$$)
15+
any:
16+
- pattern: new NullCipher($$$)
17+
- pattern: new javax.crypto.NullCipher($$$)

rules/java/security/rsa-no-padding-java.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@ note: >-
1010
rule:
1111
pattern: $YST.getInstance($MODE)
1212
constraints:
13-
MODE:
14-
regex: 'RSA/[Nn][Oo][Nn][Ee]/NoPadding'
13+
MODE:
14+
regex: "RSA/[Nn][Oo][Nn][Ee]/NoPadding"

rules/scala/security/rsa-padding-set-scala.yml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,17 @@ id: rsa-padding-set-scala
22
language: scala
33
severity: warning
44
message: >-
5-
Usage of RSA without OAEP (Optimal Asymmetric Encryption Padding) may.
5+
Usage of RSA without OAEP (Optimal Asymmetric Encryption Padding) may
6+
weaken encryption. This could lead to sensitive data exposure. Instead,
7+
use RSA with `OAEPWithMD5AndMGF1Padding` instead.
8+
69
note: >-
710
[CWE-780] Use of RSA Algorithm without OAEP
811
[REFERENCES]
912
- https://owasp.org/Top10/A02_2021-Cryptographic_Failures
1013
rule:
1114
any:
12-
- pattern: $CIPHER.getInstance($MODE)
15+
- pattern: $CIPHER.getInstance($MODE)
1316
constraints:
14-
MODE:
15-
regex: '.*RSA/.*/NoPadding.*'
17+
MODE:
18+
regex: ".*RSA/.*/NoPadding.*"

rules/swift/security/insecure-biometrics-swift.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,6 @@ note: >-
1414
- https://mobile-security.gitbook.io/mobile-security-testing-guide/ios-testing-guide/0x06f-testing-local-authentication
1515
- https://shirazkhan030.medium.com/biometric-authentication-in-ios-6c53c54f17df
1616
rule:
17-
pattern: |
18-
$X.evaluatePolicy
17+
any:
18+
- pattern: LAContext.evaluatePolicy
19+
- pattern: $X.evaluatePolicy

0 commit comments

Comments
 (0)