Made changes as per suggestions of coderabbit ai bot

Author: ESS-ENN

rules/scala/security/xmlinputfactory-dtd-enabled-scala.yml

@@ -2,24 +2,24 @@ id: xmlinputfactory-dtd-enabled-scala
 language: scala
 severity: warning
 message: >-
-      XMLInputFactory being instantiated without calling the setProperty
-      functions that are generally used for disabling entity processing. User
-      controlled data in XML Document builder can result in XML Internal Entity
-      Processing vulnerabilities like the disclosure of confidential data,
-      denial of service, Server Side Request Forgery (SSRF), port scanning. Make
-      sure to disable entity processing functionality.
+  XMLInputFactory being instantiated without calling the setProperty
+  functions that are generally used for disabling entity processing. User
+  controlled data in XML Document builder can result in XML Internal Entity
+  Processing vulnerabilities like the disclosure of confidential data,
+  denial of service, Server Side Request Forgery (SSRF), port scanning. Make
+  sure to disable entity processing functionality.
 note: >-
   [CWE-611] Improper Restriction of XML External Entity.
   [REFERENCES]
       - https://owasp.org/Top10/A05_2021-Security_Misconfiguration
 rule:
-    any:
-       - pattern: XMLInputFactory.newFactory($$$)
-       - pattern: XMLInputFactory.newInstance($$$)
-       - pattern: new XMLInputFactory($$$)
-precedes: 
-     not:
-      pattern: $XMLFACTORY.setProperty($MODE, false)
+  any:
+    - pattern: XMLInputFactory.newFactory($$$)
+    - pattern: XMLInputFactory.newInstance($$$)
+    - pattern: new XMLInputFactory($$$)
+precedes:
+  not:
+    pattern: $XMLFACTORY.setProperty($MODE, false)
 constraints:
-      MODE:
-          regex: 'javax.xml.stream.isSupportingExternalEntities'
+  MODE:
+    regex: "javax.xml.stream.isSupportingExternalEntities"

tests/__snapshots__/cbc-padding-oracle-java-snapshot.yml

@@ -6,3 +6,10 @@ snapshots:
       style: primary
       start: 0
       end: 42
+  ? |
+    Cipher.getInstance("AES/CBC/PKCS5Padding");
+  : labels:
+    - source: Cipher.getInstance("AES/CBC/PKCS5Padding")
+      style: primary
+      start: 0
+      end: 42

tests/__snapshots__/no-null-cipher-java-snapshot.yml

@@ -8,3 +8,11 @@ snapshots:
       style: primary
       start: 25
       end: 41
+  ? |
+    Cipher doNothingCihper = new NullCipher();
+    new javax.crypto.NullCipher();
+  : labels:
+    - source: new NullCipher()
+      style: primary
+      start: 25
+      end: 41

tests/__snapshots__/rsa-no-padding-java-snapshot.yml

@@ -8,3 +8,11 @@ snapshots:
       style: primary
       start: 0
       end: 40
+  ? |
+    Cipher.getInstance("RSA/None/NoPadding");
+    Cipher.getInstance("RSA/NONE/NoPadding");
+  : labels:
+    - source: Cipher.getInstance("RSA/None/NoPadding")
+      style: primary
+      start: 0
+      end: 40

tests/__snapshots__/rsa-padding-set-scala-snapshot.yml

@@ -6,3 +6,10 @@ snapshots:
       style: primary
       start: 0
       end: 39
+  ? |
+    Cipher.getInstance("RSA/ECB/NoPadding")
+  : labels:
+    - source: Cipher.getInstance("RSA/ECB/NoPadding")
+      style: primary
+      start: 0
+      end: 39

tests/__snapshots__/xmlinputfactory-dtd-enabled-scala-snapshot.yml

@@ -1,5 +1,13 @@
 id: xmlinputfactory-dtd-enabled-scala
 snapshots:
+  ? |-
+    val factory = XMLInputFactory.newFactory()
+    val fileReader = new FileReader(file)
+  : labels:
+    - source: XMLInputFactory.newFactory()
+      style: primary
+      start: 14
+      end: 42
   ? |-
     val factory = XMLInputFactory.newFactory()
     val fileReader = new FileReader(file)

tests/java/cbc-padding-oracle-java-test.yml

@@ -4,4 +4,4 @@ valid:
     Cipher.getInstance("AES/GCM/NoPadding");
 invalid:
   - |
-    Cipher.getInstance("AES/CBC/PKCS5Padding");
+    Cipher.getInstance("AES/CBC/PKCS5Padding");

tests/java/no-null-cipher-java-test.yml

@@ -5,4 +5,4 @@ valid:
 invalid:
   - |
     Cipher doNothingCihper = new NullCipher();
-    new javax.crypto.NullCipher();
+    new javax.crypto.NullCipher();

tests/java/rsa-no-padding-java-test.yml

@@ -5,4 +5,4 @@ valid:
 invalid:
   - |
     Cipher.getInstance("RSA/None/NoPadding");
-    Cipher.getInstance("RSA/NONE/NoPadding");
+    Cipher.getInstance("RSA/NONE/NoPadding");

tests/scala/rsa-padding-set-scala-test.yml

@@ -6,4 +6,4 @@ valid:
     Cipher cipher = Cipher.getInstance("AES/CBC/PKCS5Padding");
 invalid:
   - |
-    Cipher.getInstance("RSA/ECB/NoPadding")
+    Cipher.getInstance("RSA/ECB/NoPadding")