-
Notifications
You must be signed in to change notification settings - Fork 11
Turn it on 🚀 (fix build, update ci) #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d2c50e9
to
dc1bfec
Compare
ln -sf /usr/bin/php7 /usr/bin/php | ||
|
||
# Bring composer | ||
COPY --from=composer /usr/bin/composer /usr/local/bin/composer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL: If I got this right, it is going to copy /usr/bin/composer
from the composer
base image (in DockerHub I guess) into /usr/local/bin/composer
, is that right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, pretty cool right ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed
composer
installation to be extracted from thecomposer
imagecircleci
configurationmake build
)make test
)citest
fromMakefile
since it was an alias fortest