Skip to content

Turn it on 🚀 (fix build, update ci) #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 10, 2021
Merged

Turn it on 🚀 (fix build, update ci) #53

merged 11 commits into from
Sep 10, 2021

Conversation

f-moya
Copy link
Contributor

@f-moya f-moya commented Sep 7, 2021 •
edited
Loading

  • Modify composer installation to be extracted from the composer image
  • Temporary skip failing spec
  • Update circleci configuration
    • Delete existing steps
    • Create build step (make build)
    • Create new test step (make test)
    • Create workflow
    • Create release step
  • Delete citest from Makefile since it was an alias for test

@f-moya f-moya force-pushed the update-ci branch 2 times, most recently from d2c50e9 to dc1bfec Compare September 7, 2021 23:13
@f-moya f-moya marked this pull request as ready for review September 8, 2021 00:00
filipesperandio
filipesperandio approved these changes Sep 10, 2021
View reviewed changes
Dockerfile
ln -sf /usr/bin/php7 /usr/bin/php

# Bring composer
COPY --from=composer /usr/bin/composer /usr/local/bin/composer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL: If I got this right, it is going to copy /usr/bin/composer from the composer base image (in DockerHub I guess) into /usr/local/bin/composer, is that right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly, pretty cool right ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed

@f-moya f-moya merged commit a17fab7 into master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipesperandio filipesperandio filipesperandio approved these changes

@dantevvp dantevvp dantevvp approved these changes

Assignees

@filipesperandio filipesperandio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@f-moya @filipesperandio @dantevvp