Revert "Do not raise error on unsupported plugins (#204)" #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ffff4d to
d2a6f79
Compare
This was referenced Mar 16, 2017
filipesperandio
added a commit
that referenced
this pull request
Mar 17, 2017
filipesperandio
added a commit
that referenced
this pull request
Mar 17, 2017
filipesperandio
added a commit
that referenced
this pull request
Mar 20, 2017
filipesperandio
added a commit
that referenced
this pull request
Mar 20, 2017
filipesperandio
added a commit
that referenced
this pull request
Mar 20, 2017
* Bring back functionality reverted on #216. * Do not raise error on unsupported plugins * Integration tests setup * Fix #192, #213 and #214. * #192 - Don't error if we encounter a plugin we don't support * #213 - Does not raise error for invalid rules * #214 - Allow plugin extensions * Add gc support to mocha tests * All known scenarios with problematic configurations were added as integration tests. * Add a few changes to Makefile: - `make integration` - `DEBUG=true make integration` - `DEBUG=true make test` - `make citest` -> runs `npm run test && npm run integration`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a856436.
Reverting this change while we work on a fix to address #214.