Make sure it only tries to load all plugins once, avoiding noisy warnings

Related #192

Author: filipesperandio

lib/eslint-patch.js

@@ -1,29 +1,30 @@
 'use strict';
-var fs = require('fs');
-var path = require('path');
+const Plugins = require("eslint/lib/config/plugins");
 
-var Plugins = require("eslint/lib/config/plugins");
+const Config = require("eslint/lib/config");
+const ConfigUpgrader = require('./config_upgrader');
 
-var docs = require('./docs');
-var Config = require("eslint/lib/config");
-var ConfigUpgrader = require('./config_upgrader');
+const docs = require('./docs');
 
-
-module.exports = function patcher(engine) {
+module.exports = function patch(eslint) {
 
   Plugins.loadAll = function(pluginNames) {
-    for(var index in pluginNames) {
-      var name = pluginNames[index];
+    const loadedPlugins = Object.keys(Plugins.getAll());
+    if(loadedPlugins.length > 0) {
+      return;
+    }
 
+    for(const index in pluginNames) {
+      const name = pluginNames[index];
       try {
+
         Plugins.load(name);
-        console.error('>>>> Plugin loaded', name);
+
       } catch(e) {
-        console.error('>>>> Problem loading plugin', name);
+        console.error(`[DEBUG] Plugin ${name} not supported`);
       }
     }
-
-  }
+  };
 
 
   const originalGetConfig = Config.prototype.getConfig;
@@ -34,8 +35,8 @@ module.exports = function patcher(engine) {
     return configUpgrader.upgrade(originalConfig);
   };
 
-  engine.docs = docs;
+  eslint.docs = docs;
 
 
-  return engine;
+  return eslint;
 };

package.json

@@ -53,6 +53,7 @@
   "devDependencies": {
     "chai": "^3.5.0",
     "mocha": "^2.5.3",
+    "sinon": "^1.17.7",
     "temp": "^0.8.3"
   },
   "scripts": {

test/eslint-patch_test.js

@@ -1,14 +1,57 @@
-var eslint = require("eslint");
-var expect = require("chai").expect;
+const expect = require("chai").expect;
+const sinon = require("sinon");
+const eslint = require("eslint");
+
+const Plugins = require('eslint/lib/config/plugins');
+const patch = require("../lib/eslint-patch");
 
 describe('eslint-patch', function() {
-  it('intercept plugins', function() {
-    var Plugins = require('eslint/lib/config/plugins');
-    var loadAll = Plugins.loadAll;
+  let loadAll;
 
-    var patch = require("../lib/eslint-patch");
+  before(function() {
+    loadAll = Plugins.loadAll;
     patch(eslint);
+  });
+
+  after(function() {
+    Plugins.loadAll = loadAll;
+  });
 
+  it('intercept plugins', function() {
     expect(loadAll).to.not.equal(Plugins.loadAll, 'Plugins.loadAll is not patched');
   });
+
+  describe('Plugins.loadAll', function() {
+    it('delegates each plugin to be loaded', function () {
+      Plugins.getAll = sinon.stub().returns([]);
+      Plugins.load = sinon.spy();
+
+      Plugins.loadAll([ "jasmine", "mocha"  ]);
+
+      expect(Plugins.load.calledWith("jasmine")).to.be.true;
+      expect(Plugins.load.calledWith("mocha")).to.be.true;
+    });
+
+    it('only load plugins once', function () {
+      Plugins.getAll = sinon.stub().returns([ "node" ]);
+      Plugins.load = sinon.spy();
+
+      Plugins.loadAll([ "node" ]);
+
+      expect(Plugins.load.called).to.be.false;
+    });
+
+    it('does not raise exception for unsupported plugins', function() {
+      Plugins.getAll = sinon.stub().returns([]);
+      Plugins.load = sinon.stub().throws();
+
+      function loadPlugin() {
+        Plugins.loadAll([ 'unsupported-plugin' ]);
+      }
+
+      expect(loadPlugin).to.not.throw();
+    });
+
+  });
+
 });

yarn.lock

@@ -839,6 +839,12 @@ foreach@^2.0.5:
   version "2.0.5"
   resolved "https://registry.yarnpkg.com/foreach/-/foreach-2.0.5.tgz#0bee005018aeb260d0a3af3ae658dd0136ec1b99"
 
+[email protected]:
+  version "1.1.1"
+  resolved "https://registry.yarnpkg.com/formatio/-/formatio-1.1.1.tgz#5ed3ccd636551097383465d996199100e86161e9"
+  dependencies:
+    samsam "~1.1"
+
 fs.realpath@^1.0.0:
   version "1.0.0"
   resolved "https://registry.yarnpkg.com/fs.realpath/-/fs.realpath-1.0.0.tgz#1504ad2523158caa40db4a2787cb01411994ea4f"
@@ -959,6 +965,10 @@ inherits@2, inherits@~2.0.1:
   version "2.0.3"
   resolved "https://registry.yarnpkg.com/inherits/-/inherits-2.0.3.tgz#633c2c83e3da42a502f52466022480f4208261de"
 
+[email protected]:
+  version "2.0.1"
+  resolved "https://registry.yarnpkg.com/inherits/-/inherits-2.0.1.tgz#b17d08d326b4423e568eff719f91b0b1cbdf69f1"
+
 inquirer@^0.12.0:
   version "0.12.0"
   resolved "https://registry.yarnpkg.com/inquirer/-/inquirer-0.12.0.tgz#1ef2bfd63504df0bc75785fff8c2c41df12f077e"
@@ -1132,6 +1142,10 @@ lodash@^4.0.0, lodash@^4.15.0, lodash@^4.2.0, lodash@^4.3.0, lodash@^4.5.1:
   version "4.17.2"
   resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.2.tgz#34a3055babe04ce42467b607d700072c7ff6bf42"
 
+[email protected]:
+  version "1.3.2"
+  resolved "https://registry.yarnpkg.com/lolex/-/lolex-1.3.2.tgz#7c3da62ffcb30f0f5a80a2566ca24e45d8a01f31"
+
 loose-envify@^1.0.0:
   version "1.3.0"
   resolved "https://registry.yarnpkg.com/loose-envify/-/loose-envify-1.3.0.tgz#6b26248c42f6d4fa4b0d8542f78edfcde35642a8"
@@ -1414,6 +1428,10 @@ safe-regex@^1.1.0:
   dependencies:
     ret "~0.1.10"
 
+[email protected], samsam@~1.1:
+  version "1.1.2"
+  resolved "https://registry.yarnpkg.com/samsam/-/samsam-1.1.2.tgz#bec11fdc83a9fda063401210e40176c3024d1567"
+
 [email protected]:
   version "5.3.0"
   resolved "https://registry.yarnpkg.com/semver/-/semver-5.3.0.tgz#9b2ce5d3de02d17c6012ad326aa6b4d0cf54f94f"
@@ -1430,6 +1448,15 @@ sigmund@~1.0.0:
   version "1.0.1"
   resolved "https://registry.yarnpkg.com/sigmund/-/sigmund-1.0.1.tgz#3ff21f198cad2175f9f3b781853fd94d0d19b590"
 
+sinon@^1.17.7:
+  version "1.17.7"
+  resolved "https://registry.yarnpkg.com/sinon/-/sinon-1.17.7.tgz#4542a4f49ba0c45c05eb2e9dd9d203e2b8efe0bf"
+  dependencies:
+    formatio "1.1.1"
+    lolex "1.3.2"
+    samsam "1.1.2"
+    util ">=0.10.3 <1"
+
 slash@^1.0.0:
   version "1.0.0"
   resolved "https://registry.yarnpkg.com/slash/-/slash-1.0.0.tgz#c41f2f6c39fc16d1cd17ad4b5d896114ae470d55"
@@ -1563,6 +1590,12 @@ util-deprecate@~1.0.1:
   version "1.0.2"
   resolved "https://registry.yarnpkg.com/util-deprecate/-/util-deprecate-1.0.2.tgz#450d4dc9fa70de732762fbd2d4a28981419a0ccf"
 
+"util@>=0.10.3 <1":
+  version "0.10.3"
+  resolved "https://registry.yarnpkg.com/util/-/util-0.10.3.tgz#7afb1afe50805246489e3db7fe0ed379336ac0f9"
+  dependencies:
+    inherits "2.0.1"
+
 wordwrap@~1.0.0:
   version "1.0.0"
   resolved "https://registry.yarnpkg.com/wordwrap/-/wordwrap-1.0.0.tgz#27584810891456a4171c8d0226441ade90cbcaeb"