Fix check-details keys #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
I originally thought source (which we use as check-name) was a munged
version of the rule-id[1]:
id: import => source: net.csslint.Import
It's actually a munged versions of rule-name[2]:
name: Disallow @import => net.css.lint.Disallow@import
This commit corrects the CheckDetails map keys to use what is actually
emitted as source.
1: https://github.com/CSSLint/csslint/blob/f69cf12e23ca95cfd9e78a4a5d83fdccb71bb8be/src/rules/import.js#L8
2: https://github.com/CSSLint/csslint/blob/f69cf12e23ca95cfd9e78a4a5d83fdccb71bb8be/src/rules/import.js#L9
23e62c4 to
f3c5f51
Compare
|
@pbrisbin while you're in here: |
|
nvm. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally thought source (which we use as check-name) was a munged version
of the rule-id[1]:
It's actually a munged versions of rule-name[2]:
This commit corrects the CheckDetails map keys to use what is actually emitted
as source.
1: https://github.com/CSSLint/csslint/blob/f69cf12e23ca95cfd9e78a4a5d83fdccb71bb8be/src/rules/import.js#L8
2: https://github.com/CSSLint/csslint/blob/f69cf12e23ca95cfd9e78a4a5d83fdccb71bb8be/src/rules/import.js#L9
/cc @codeclimate/review