Skip to content

update checkstyle to version 10.7.0 #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 16, 2023

Conversation

RubyBrewsday
Copy link

Jira Ticket: https://codeclimate.atlassian.net/browse/QUA-701

Checkstyle Changelog: https://github.com/checkstyle/checkstyle/releases

This goes from version 8.39, to 10.7.0, which also allow for checking with Google Checkstyles.

@RubyBrewsday RubyBrewsday requested a review from f-moya February 13, 2023 13:43
@RubyBrewsday RubyBrewsday requested review from a team and dantevvp and removed request for a team February 16, 2023 14:24
Copy link
Contributor

@dantevvp dantevvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this branch was created right before merging the new GCR -> Dockerhub changes. What do you think about copying the logic from the master branch to also only push this image to Dockerhub? This engine is also already removed from shipbot so if we upload it to GCR only, shipbot will not perform the push to Dockerhub

Copy link
Contributor

@dantevvp dantevvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RubyBrewsday RubyBrewsday merged commit b753562 into channel/checkstyle-10-7-0 Feb 16, 2023
@RubyBrewsday RubyBrewsday deleted the qua-701/checkstyle-10-7-0 branch February 16, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants