Support additional fees for payment requests #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c1dd4ed to
98f411d
Compare
28c4daf to
5752c59
Compare
1df099f to
beefc58
Compare
…ue to fluctuating exchange rates
348134a to
403f832
Compare
jeffyanta
added a commit
that referenced
this pull request
Feb 23, 2024
* Update request stores to include fee metadata * Add basis points to payment request fee model * Ensure consistent fee ordering from DB store * Pull in v1.10.0 protobuf APIs * Support additional fee takers in SubmitIntent * Add edge case tests for SubmitIntent when using additional fee takers * Ensure additional third party fees are subtracted from RECEIVED chat messages * Support additional fee takers in messaging service * Add happy path tests for additional fees in messaging service * Add edge case tests for additional fees in messaging service * Improve error messaging to distinguish between fee taker and payment destination * Update merchant chats to consider fees to Code accounts * Be more strict about wasteful fees * Max fee basis points is now configurable * Add tests for new fee edge cases in messaging service * Update scheduler test to ensure multiple fees are handled * Add local simulation test to ensure we catch invalid fee structures due to fluctuating exchange rates * Add client-side assertions on fee server parameter expectations * Add a test for getMicroPaymentReceiveExchangeDataByOwner * Fix micropayment check in getMicroPaymentReceiveExchangeDataByOwner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.