Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "shell: Deprecate host switcher in current OS releases" #20829

Closed

Conversation

martinpitt
Copy link
Member

@martinpitt martinpitt commented Aug 1, 2024

This gets challenged/debated heavily, see #20823

Reopens https://issues.redhat.com/browse/COCKPIT-1149 and https://issues.redhat.com/browse/COCKPIT-870

This reverts commit ee3262e.

Fixes #20823


I give up. Whoever else wants to take this up, I'm not that any more. I the past and following weeks I'm unfortunately unable health-wise to contribute anything significant to this.

@martinpitt martinpitt added the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Aug 1, 2024
@martinpitt martinpitt removed the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Aug 1, 2024
@martinpitt martinpitt marked this pull request as ready for review August 1, 2024 09:34
@garrett
Copy link
Member

garrett commented Aug 1, 2024

I think you might misunderstand?

The discussion isn't to not deprecate it; the discussion is to not immediately break the feature for everyone, and to quickly adjust the configuration file to apply to RHEL10 only for now, so Cockpit would land in RHEL10 (specifically) without the host switcher by default.

And after the next release (due to time constraints), then work on messaging this in a better way (in Cockpit itself, in addition to the website and Mastodon) so people know that it's coming and can prepare. As it stands in main right now, without these adjustments, when people upgrade Cockpit (on their non-RHEL systems), they'll find out that the feature they depended on is semi-broken with no explanation as to why or what to do next. The discussion is to prevent that confusion for everyone on non-RHEL systems, and to prevent Cockpit from looking broken or acting in a semi-broken state.

@martinpitt
Copy link
Member Author

@garrett I didn't closely follow the discussion. Do with this as you may, it's just one option. Thanks!

@mvollmer
Copy link
Member

mvollmer commented Aug 1, 2024

I give up.

Nah, just take some rest.

@garrett
Copy link
Member

garrett commented Aug 1, 2024

I agree with @mvollmer. @martinpitt, please do get some rest and I'm sorry for causing distress over this. We're handling it.

We're not tossing away your work on this; we're revising it and making sure the RHEL case is covered immediately and we're working to cover everything else too, hopefully making everyone happy enough in the longer run.

@martinpitt
Copy link
Member Author

OK! Don't worry, this wasn't much work, I just wasn't sure if you rather wanted to start from scratch or from current main.

@martinpitt martinpitt closed this Aug 2, 2024
@martinpitt martinpitt deleted the revert-host-switcher branch August 2, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address issues with host switcher removal before releasing Cockpit with this feature
3 participants