Skip to content

Feat: Add dust calculation #2010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Feat: Add dust calculation #2010

wants to merge 1 commit into from

Conversation

junderw
Copy link
Member

@junderw junderw commented Dec 3, 2023

Fixes #2009

arik-so
arik-so reviewed Dec 3, 2023
View reviewed changes
arik-so
arik-so approved these changes Dec 3, 2023
View reviewed changes
Copy link
Contributor

@arik-so arik-so left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the output types I am already familiar with definitely align perfectly with the values we know from Bitcoin Core.

@junderw
Copy link
Member Author

junderw commented Dec 5, 2023

I changed it to sat/vb, but idk, maybe we should match the unit that Core uses........ I doubt anyone will ever use any unit that isn't default anyways.

@junderw junderw added this to the 7.0.0 milestone Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@arik-so arik-so arik-so approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

Feature request: Dust threshold value based on output script
2 participants
@junderw @arik-so