twinkle.js: Update Twinkle.addPortlet() to work after recent MW changes #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vector's dropdown menu styles were recently cleaned up and a label is now shown by default (https://gerrit.wikimedia.org/r/#/c/112236/), hacks that Twinkle has been doing are no longer needed and in fact break the display (https://en.wikipedia.org/wiki/WP:VPT#Misinterface_layout). The README is pretty confusing, I hope this is the right file to edit (I didn't find this code in any other one).
azatoth
added a commit
that referenced
this pull request
Jun 13, 2014
twinkle.js: Update Twinkle.addPortlet() to work after recent MW changes
|
Thanks for this, Bartosz. Yeah the readme needs some work. It's mainly intended for people involved in updating the gadget on-wiki. I think the file structure of this repo is fairly obvious, but maybe it's just me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vector's dropdown menu styles were recently cleaned up and a label is
now shown by default (https://gerrit.wikimedia.org/r/#/c/112236/),
hacks that Twinkle has been doing are no longer needed and in fact
break the display (https://en.wikipedia.org/wiki/WP:VPT#Misinterface_layout).
The README is pretty confusing, I hope this is the right file to edit
(I didn't find this code in any other one).