Skip to content

Tools: Normalize & enforce SPDX headers #5811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 16, 2024
Merged

Tools: Normalize & enforce SPDX headers #5811

merged 4 commits into from
Jan 16, 2024

Conversation

DavidSouther
Copy link
Contributor

This pull request normalizes SPDX headers across all files, and enforces SPDX format going forward.

Closes #5720

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added C++ This issue relates to the AWS SDK for C++ DotNet-v3 This issue relates to the AWS SDK for .NET V3 Go-v1 This issue relates to the AWS SDK for Go V1 Go-v2 This issue relates to the AWS SDK for Go V2 Java-v1 This issue relates to the AWS SDK for Java V1 Javascript-v2 This issue relates to the AWS SDK for Javascript V2 Javascript-v3 This issue relates to the AWS SDK for Javascript V3 CLI Relates to the AWS CLI Java-v2 This issue relates to the AWS SDK for Java V2 GitHub settings This affects GitHub settings Tools This issue relates to a custom tooling to streamline development tasks labels Dec 20, 2023
rlhagerm
rlhagerm approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@rlhagerm rlhagerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one question on the actual code changes, to be sure those lines were intended to be commented out.

@DavidSouther DavidSouther marked this pull request as draft December 22, 2023 18:48
@DavidSouther DavidSouther added the On Call Review needed This work needs an on-call review label Jan 12, 2024
@DavidSouther DavidSouther marked this pull request as ready for review January 12, 2024 19:18
@beqqrry-aws beqqrry-aws added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Jan 12, 2024
@beqqrry-aws beqqrry-aws added the Task A general update to the code base for language clarification, missing actions, tests, etc. label Jan 16, 2024
@beqqrry-aws beqqrry-aws merged commit de7b1ee into awsdocs:main Jan 16, 2024
@DavidSouther DavidSouther deleted the tools/spdx branch January 16, 2024 20:25
@meyertst-aws meyertst-aws mentioned this pull request Jan 22, 2024
Closed
@ford-at-aws ford-at-aws mentioned this pull request Jan 31, 2024
Merged
max-webster pushed a commit to max-webster/aws-doc-sdk-examples that referenced this pull request Mar 15, 2024
@DavidSouther @max-webster
Tools: Normalize & enforce SPDX headers (awsdocs#5811)
a52345f
patriciakid
patriciakid reviewed Aug 31, 2024
View reviewed changes
Copy link

@patriciakid patriciakid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M

patriciakid
patriciakid suggested changes Aug 31, 2024
View reviewed changes
Copy link

@patriciakid patriciakid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patriciakid patriciakid patriciakid requested changes

@rlhagerm rlhagerm rlhagerm approved these changes

Assignees

@DavidSouther DavidSouther

Labels
C++ This issue relates to the AWS SDK for C++ CLI Relates to the AWS CLI DotNet-v3 This issue relates to the AWS SDK for .NET V3 GitHub settings This affects GitHub settings Go-v1 This issue relates to the AWS SDK for Go V1 Go-v2 This issue relates to the AWS SDK for Go V2 Java-v1 This issue relates to the AWS SDK for Java V1 Java-v2 This issue relates to the AWS SDK for Java V2 Javascript-v2 This issue relates to the AWS SDK for Javascript V2 Javascript-v3 This issue relates to the AWS SDK for Javascript V3 On Call Review complete On call review complete Task A general update to the code base for language clarification, missing actions, tests, etc. Tools This issue relates to a custom tooling to streamline development tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tools: Create GHA to enforce SPDX headers
4 participants
@DavidSouther @rlhagerm @patriciakid @beqqrry-aws