revert: do not use node: protocol for imports (#3651)

It requires node 14.18.0 or greater, which is way more recent than
the earliest node engine we claim to support.



---

By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0

Author: RomainMuller

eslint-config.yaml

@@ -8,7 +8,6 @@ plugins:
   - '@typescript-eslint'
   - import
   - prettier
-  - unicorn
 
 parser: '@typescript-eslint/parser'
 parserOptions:
@@ -44,9 +43,6 @@ rules:
   'prettier/prettier':
     - error
 
-  'unicorn/prefer-node-protocol':
-    - error
-
   '@typescript-eslint/array-type':
     - error
     - default: array-simple

package.json

@@ -27,7 +27,6 @@
     "eslint-import-resolver-typescript": "^3.2.4",
     "eslint-plugin-import": "^2.26.0",
     "eslint-plugin-prettier": "^4.2.1",
-    "eslint-plugin-unicorn": "^43.0.0",
     "jest": "^28.1.2",
     "jest-circus": "^28.1.2",
     "jest-config": "^28.1.2",

packages/@jsii/benchmarks/bin/benchmark.ts

@@ -1,5 +1,5 @@
 import * as fs from 'fs-extra';
-import * as path from 'node:path';
+import * as path from 'path';
 import * as yargs from 'yargs';
 
 import { benchmarks } from '../lib';

packages/@jsii/benchmarks/lib/benchmark.ts

@@ -1,9 +1,5 @@
-import { Profiler, Session } from 'node:inspector';
-import {
-  performance,
-  PerformanceObserver,
-  PerformanceEntry,
-} from 'node:perf_hooks';
+import { Profiler, Session } from 'inspector';
+import { performance, PerformanceObserver, PerformanceEntry } from 'perf_hooks';
 
 /**
  * Result of a single run of the subject

packages/@jsii/benchmarks/lib/constants.ts

@@ -1,4 +1,4 @@
-import * as path from 'node:path';
+import * as path from 'path';
 
 export const fixturesDir = path.resolve(__dirname, '..', 'fixtures');
 

packages/@jsii/benchmarks/lib/suite/aws-cdk-lib/build-with-jsii.ts

@@ -1,7 +1,7 @@
 import { Compiler } from 'jsii/lib/compiler';
 import { loadProjectInfo } from 'jsii/lib/project-info';
-import * as path from 'node:path';
-import * as process from 'node:process';
+import * as path from 'path';
+import * as process from 'process';
 import * as ts from 'typescript';
 
 import type { Context } from '.';

packages/@jsii/benchmarks/lib/suite/aws-cdk-lib/build-with-tsc.ts

@@ -1,6 +1,6 @@
 import * as fs from 'fs-extra';
-import * as path from 'node:path';
-import * as process from 'node:process';
+import * as path from 'path';
+import * as process from 'process';
 import * as ts from 'typescript';
 
 import type { Context } from '.';

packages/@jsii/benchmarks/lib/suite/aws-cdk-lib/index.ts

@@ -1,7 +1,7 @@
+import * as cp from 'child_process';
 import * as fs from 'fs-extra';
-import * as cp from 'node:child_process';
-import * as os from 'node:os';
-import * as path from 'node:path';
+import * as os from 'os';
+import * as path from 'path';
 
 import { cdkTag, cdk } from '../../constants';
 import { inDirectory, streamUntar } from '../../util';

packages/@jsii/benchmarks/scripts/snapshot-package.ts

@@ -1,8 +1,8 @@
+import * as cp from 'child_process';
 import * as fs from 'fs-extra';
 import * as glob from 'glob';
-import * as cp from 'node:child_process';
-import * as os from 'node:os';
-import * as path from 'node:path';
+import * as os from 'os';
+import * as path from 'path';
 import * as tar from 'tar';
 import * as ts from 'typescript';
 

packages/@jsii/check-node/src/constants.ts

@@ -1,4 +1,4 @@
-import * as process from 'node:process';
+import * as process from 'process';
 import { Range, SemVer } from 'semver';
 
 const ONE_DAY_IN_MILLISECONDS = 86_400_000;