Fix edge cases when parsing subproperties (#2359)

Author: isaiahvita

.changelog/d767f490a7f644ebb9eb36f126053870.json

@@ -0,0 +1,9 @@
+{
+    "id": "d767f490-a7f6-44eb-b9eb-36f126053870",
+    "type": "feature",
+    "description": "BREAKFIX: In order to support subproperty parsing, invalid property definitions must not be ignored",
+    "modules": [
+        "internal/ini",
+        "config"
+    ]
+}

config/shared_config_test.go

@@ -25,6 +25,8 @@ var (
 	testConfigFilename      = filepath.Join("testdata", "shared_config")
 	testConfigOtherFilename = filepath.Join("testdata", "shared_config_other")
 	testCredentialsFilename = filepath.Join("testdata", "shared_credentials")
+	testConfigLeadingWSFilename1 = filepath.Join("testdata", "leading_ws")
+	testConfigLeadingWSFilename2 = filepath.Join("testdata", "leading_ws_trailing_nl")
 )
 
 func TestNewSharedConfig(t *testing.T) {
@@ -685,6 +687,16 @@ func TestNewSharedConfig(t *testing.T) {
 				EC2IMDSv1Disabled: aws.Bool(false),
 			},
 		},
+		"leading whitespace error 1": {
+			ConfigFilenames: []string{testConfigLeadingWSFilename1},
+			Profile:         "leading-whitespace-error",
+			Err:             fmt.Errorf("Invalid token, remove leading whitespace"),
+		},
+		"leading whitespace error 2": {
+			ConfigFilenames: []string{testConfigLeadingWSFilename2},
+			Profile:         "leading-whitespace-error",
+			Err:             fmt.Errorf("Invalid token, remove leading whitespace"),
+		},
 	}
 
 	for name, c := range cases {

config/testdata/leading_ws

@@ -0,0 +1,2 @@
+	[profile leading-whitespace-error]
+	retry_mode = standard

config/testdata/leading_ws_trailing_nl

@@ -0,0 +1,3 @@
+	[profile leading-whitespace-error]
+	retry_mode = standard
+

internal/ini/ini_parser.go

@@ -187,6 +187,13 @@ loop:
 			stack.Push(k)
 		case StatementState:
 			if k.Kind != ASTKindStart {
+				if tok.Type() == TokenLit && isSubProperty(tok.raw) {
+					return nil, NewParseError(
+						fmt.Sprintf(
+							"Invalid token, remove leading whitespace %s",
+							string(tok.raw)),
+					)
+				}
 				stack.MarkComplete(k)
 			}
 			expr := newExpression(tok)

internal/ini/literal_tokens.go

@@ -178,7 +178,7 @@ func getSubProperty(runes []rune, offset int) (int, error) {
 			return offset + idx, nil
 		}
 	}
-	return 0, fmt.Errorf("no sub property")
+	return offset + len(runes), nil
 }
 
 // MapValue returns a map value for sub properties