Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aws/aws-cdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.108.0
Choose a base ref
...
head repository: aws/aws-cdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.108.1
Choose a head ref
  • 5 commits
  • 15 files changed
  • 5 contributors

Commits on Nov 14, 2023

  1. fix(elasticloadbalancingv2): access logging fails on imported bucket (#… 

    …27948)

#27558 fixed a circular dependency issue between the bucket and the ELB when using `logAccessLogs` by adding the dependency at the L1 level.
The dependency was added on both the bucket and the bucket policy (which already refers to the bucket).

This introduced a new bug when adding a dependency for imported buckets (as `bucket.node.defaultChild` is `undefined`).

This PR fixes the issue by adding the dependency at the L1 level on the bucket policy directly.

Closes #27928.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    @lpizzinidev @kaizencc
    lpizzinidev authored and kaizencc committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    8243601 View commit details
    Browse the repository at this point in the history

  2. chore(release): 2.108.1

    @kaizencc
    kaizencc committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    bdc2355 View commit details
    Browse the repository at this point in the history

  3. fix changelog

    @kaizencc
    kaizencc committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    61c2056 View commit details
    Browse the repository at this point in the history

  4. Update CHANGELOG.v2.alpha.md 

    Co-authored-by: Mitchell Valine <[email protected]>
    @kaizencc @MrArnoldPalmer
    kaizencc and MrArnoldPalmer authored Nov 14, 2023
    Configuration menu
    Copy the full SHA
    b1bf06f View commit details
    Browse the repository at this point in the history

  5. chore(release): 2.108.1 (#27992) 

    See CHANGELOG.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    @mergify
    mergify[bot] authored Nov 14, 2023
    Configuration menu
    Copy the full SHA
    2320255 View commit details
    Browse the repository at this point in the history
Loading