feat(appconfig): throw ValidationError instead of untyped Errors (#33386)

### Issue 

Relates to #32569 

### Description of changes

`ValidationErrors` everywhere

### Describe any new or updated permissions being added

n/a

### Description of how you validated changes

Existing tests. Exemptions granted as this is a refactor of existing code.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Author: mrgrain

packages/aws-cdk-lib/.eslintrc.js

@@ -23,6 +23,7 @@ const enableNoThrowDefaultErrorIn = [
   'aws-apigatewayv2',
   'aws-apigatewayv2-authorizers',
   'aws-apigatewayv2-integrations',
+  'aws-appconfig',
   'aws-applicationautoscaling',
   'aws-appsync',
   'aws-appmesh',

packages/aws-cdk-lib/aws-appconfig/lib/application.ts

@@ -346,7 +346,7 @@ export class Application extends ApplicationBase {
     const parsedArn = cdk.Stack.of(scope).splitArn(applicationArn, cdk.ArnFormat.SLASH_RESOURCE_NAME);
     const applicationId = parsedArn.resourceName;
     if (!applicationId) {
-      throw new Error('Missing required application id from application ARN');
+      throw new cdk.ValidationError('Missing required application id from application ARN', scope);
     }
 
     class Import extends ApplicationBase {

packages/aws-cdk-lib/aws-appconfig/lib/deployment-strategy.ts

@@ -1,6 +1,6 @@
 import { Construct } from 'constructs';
 import { CfnDeploymentStrategy } from './appconfig.generated';
-import { Resource, IResource, Stack, ArnFormat, Names, Duration } from '../../core';
+import { Resource, IResource, Stack, ArnFormat, Names, Duration, ValidationError } from '../../core';
 import { addConstructMetadata } from '../../core/lib/metadata-resource';
 
 /**
@@ -47,7 +47,7 @@ export class DeploymentStrategy extends Resource implements IDeploymentStrategy
     const parsedArn = Stack.of(scope).splitArn(deploymentStrategyArn, ArnFormat.SLASH_RESOURCE_NAME);
     const deploymentStrategyId = parsedArn.resourceName;
     if (!deploymentStrategyId) {
-      throw new Error('Missing required deployment strategy id from deployment strategy ARN');
+      throw new ValidationError('Missing required deployment strategy id from deployment strategy ARN', scope);
     }
 
     class Import extends Resource implements IDeploymentStrategy {

packages/aws-cdk-lib/aws-appconfig/lib/environment.ts

@@ -7,7 +7,7 @@ import { getHash } from './private/hash';
 import { DeletionProtectionCheck } from './util';
 import * as cloudwatch from '../../aws-cloudwatch';
 import * as iam from '../../aws-iam';
-import { Resource, IResource, Stack, ArnFormat, PhysicalName, Names } from '../../core';
+import { Resource, IResource, Stack, ArnFormat, PhysicalName, Names, ValidationError, UnscopedValidationError } from '../../core';
 import { addConstructMetadata } from '../../core/lib/metadata-resource';
 
 /**
@@ -56,7 +56,7 @@ abstract class EnvironmentBase extends Resource implements IEnvironment, IExtens
 
   public addDeployment(configuration: IConfiguration): void {
     if (this.name === undefined) {
-      throw new Error('Environment name must be known to add a Deployment');
+      throw new ValidationError('Environment name must be known to add a Deployment', this);
     }
 
     const queueSize = this.deploymentQueue.push(
@@ -203,12 +203,12 @@ export class Environment extends EnvironmentBase {
   public static fromEnvironmentArn(scope: Construct, id: string, environmentArn: string): IEnvironment {
     const parsedArn = Stack.of(scope).splitArn(environmentArn, ArnFormat.SLASH_RESOURCE_NAME);
     if (!parsedArn.resourceName) {
-      throw new Error(`Missing required /$/{applicationId}/environment//$/{environmentId} from environment ARN: ${parsedArn.resourceName}`);
+      throw new ValidationError(`Missing required /$/{applicationId}/environment//$/{environmentId} from environment ARN: ${parsedArn.resourceName}`, scope);
     }
 
     const resourceName = parsedArn.resourceName.split('/');
     if (resourceName.length != 3 || !resourceName[0] || !resourceName[2]) {
-      throw new Error('Missing required parameters for environment ARN: format should be /$/{applicationId}/environment//$/{environmentId}');
+      throw new ValidationError('Missing required parameters for environment ARN: format should be /$/{applicationId}/environment//$/{environmentId}', scope);
     }
 
     const applicationId = resourceName[0];
@@ -413,7 +413,7 @@ export abstract class Monitor {
    */
   public static fromCfnMonitorsProperty(monitorsProperty: CfnEnvironment.MonitorsProperty): Monitor {
     if (monitorsProperty.alarmArn === undefined) {
-      throw new Error('You must specify an alarmArn property to use "fromCfnMonitorsProperty".');
+      throw new UnscopedValidationError('You must specify an alarmArn property to use "fromCfnMonitorsProperty".');
     }
     return {
       alarmArn: monitorsProperty.alarmArn,

packages/aws-cdk-lib/aws-appconfig/lib/extension.ts

@@ -6,7 +6,7 @@ import * as iam from '../../aws-iam';
 import * as lambda from '../../aws-lambda';
 import * as sns from '../../aws-sns';
 import * as sqs from '../../aws-sqs';
-import { ArnFormat, IResource, Names, PhysicalName, Resource, Stack } from '../../core';
+import { ArnFormat, IResource, Names, PhysicalName, Resource, Stack, ValidationError } from '../../core';
 import { addConstructMetadata } from '../../core/lib/metadata-resource';
 
 /**
@@ -393,12 +393,12 @@ export class Extension extends Resource implements IExtension {
   public static fromExtensionArn(scope: Construct, id: string, extensionArn: string): IExtension {
     const parsedArn = Stack.of(scope).splitArn(extensionArn, ArnFormat.SLASH_RESOURCE_NAME);
     if (!parsedArn.resourceName) {
-      throw new Error(`Missing required /$/{extensionId}//$/{extensionVersionNumber} from configuration profile ARN: ${parsedArn.resourceName}`);
+      throw new ValidationError(`Missing required /$/{extensionId}//$/{extensionVersionNumber} from configuration profile ARN: ${parsedArn.resourceName}`, scope);
     }
 
     const resourceName = parsedArn.resourceName.split('/');
     if (resourceName.length != 2 || !resourceName[0] || !resourceName[1]) {
-      throw new Error('Missing required parameters for extension ARN: format should be /$/{extensionId}//$/{extensionVersionNumber}');
+      throw new ValidationError('Missing required parameters for extension ARN: format should be /$/{extensionId}//$/{extensionVersionNumber}', scope);
     }
 
     const extensionId = resourceName[0];