Skip to content

Commit a2eb092

Browse files
author
Elad Ben-Israel
authored
revert: "chore(ec2): enforceSSL on flowLog s3 bucket (#18271)" (#18770)
#18271 resulted in the definition of a new bucket policy, which broke existing users that already had an implicit bucket policy created by AWS (see [docs](https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/AWS-logs-and-resource-policy.html#AWS-logs-infrastructure-S3)). Reverts commit 0ed5e85 in the meantime until we figure out the longer term solution. Fixes #18676 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 121e4a1 commit a2eb092

File tree

2 files changed

+0
-48
lines changed

2 files changed

+0
-48
lines changed

packages/@aws-cdk/aws-ec2/lib/vpc-flow-logs.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,6 @@ class S3Destination extends FlowLogDestination {
198198
if (this.props.s3Bucket === undefined) {
199199
s3Bucket = new s3.Bucket(scope, 'Bucket', {
200200
encryption: s3.BucketEncryption.UNENCRYPTED,
201-
enforceSSL: true,
202201
removalPolicy: RemovalPolicy.RETAIN,
203202
});
204203
} else {

packages/@aws-cdk/aws-ec2/test/integ.vpc-flow-logs.expected.json

Lines changed: 0 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -527,53 +527,6 @@
527527
"UpdateReplacePolicy": "Retain",
528528
"DeletionPolicy": "Retain"
529529
},
530-
"VPCFlowLogsS3BucketPolicyB2C2A045": {
531-
"Type": "AWS::S3::BucketPolicy",
532-
"Properties": {
533-
"Bucket": {
534-
"Ref": "VPCFlowLogsS3BucketFB7DC2BE"
535-
},
536-
"PolicyDocument": {
537-
"Statement": [
538-
{
539-
"Action": "s3:*",
540-
"Condition": {
541-
"Bool": {
542-
"aws:SecureTransport": "false"
543-
}
544-
},
545-
"Effect": "Deny",
546-
"Principal": {
547-
"AWS": "*"
548-
},
549-
"Resource": [
550-
{
551-
"Fn::GetAtt": [
552-
"VPCFlowLogsS3BucketFB7DC2BE",
553-
"Arn"
554-
]
555-
},
556-
{
557-
"Fn::Join": [
558-
"",
559-
[
560-
{
561-
"Fn::GetAtt": [
562-
"VPCFlowLogsS3BucketFB7DC2BE",
563-
"Arn"
564-
]
565-
},
566-
"/*"
567-
]
568-
]
569-
}
570-
]
571-
}
572-
],
573-
"Version": "2012-10-17"
574-
}
575-
}
576-
},
577530
"VPCFlowLogsS3FlowLogB5256CFF": {
578531
"Type": "AWS::EC2::FlowLog",
579532
"Properties": {

0 commit comments

Comments
 (0)