Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aws/aws-cdk-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: [email protected]
Choose a base ref
...
head repository: aws/aws-cdk-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: [email protected]
Choose a head ref
  • 6 commits
  • 16 files changed
  • 3 contributors

Commits on Jul 2, 2025

  1. fix: CCAPI provider does not do pagination (#678)

    The CCAPI provider stops after the first page of results. This may cause
    for example EC2 Prefix Lists that exist to not be found, if they don't
    occur in the first page of results.
    
    Make the provider retrieve all pages of results.
    
    Also in this PR:
    
    - New SDK mocks had been added without them being added to all the
    places where they needed to be added to be reset properly. Instead, put
    them all into an object so we can do a reliable `for` loop that will
    never go out of date again.
    - Up the `MaxResults` to 100, so we need to do fewer paginations and the
    chances of the error message finding too many elements has a reasonable
    indicator of the number of resources actually found.
    
    Fixes #587
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    rix0rrr authored Jul 2, 2025
    Configuration menu
    Copy the full SHA
    f162c19 View commit details
    Browse the repository at this point in the history
  2. chore(cli): diff tests should not depend on message order (#680)

    This turns into an error every time we add a new message to the ioHost.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    kaizencc authored Jul 2, 2025
    Configuration menu
    Copy the full SHA
    6a4d423 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2025

  1. chore(cli): telemetry sink (#585)

    Introduces a generic telemetry sink to the cli. it is tested but not
    used anywhere.
    
    There are 3 base types of telemetry sinks:
    
    - `FileSink` -> gathers events and writes them to a file 
    - `IoHostSink` -> gathers events and sends them to the IoHost (for
    writing to stdout/err)
    - `EndpointSink` -> gathers events and sends them to an external
    endpoint, batching at intervals of 30 seconds.
    
    
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    kaizencc authored Jul 3, 2025
    Configuration menu
    Copy the full SHA
    4c14220 View commit details
    Browse the repository at this point in the history
  2. chore(cli): cli type registry json (#682)

    Pulling out of #631.
    
    This is relevant for telemetry but also helpful in general to compile
    the [dynamic] source of truth in `cli-config.ts` into a static json for
    our viewing pleasure.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    kaizencc authored Jul 3, 2025
    Configuration menu
    Copy the full SHA
    64d88d9 View commit details
    Browse the repository at this point in the history
  3. chore: make the environment deterministic for test stack (#684)

    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    otaviomacedo authored Jul 3, 2025
    Configuration menu
    Copy the full SHA
    7b10fee View commit details
    Browse the repository at this point in the history
  4. fix(integ-runner): snapshots involving AZs are different if `enableLo…

    …okups: false` (#685)
    
    In #666 we used `synthFast()` to
    always generate a snapshot in the same was as was used for validating
    (which was also using `synthFast()`).
    
    The difference being, that the context we load depends on the
    `enableLookups: false|true` flag that's passed to `new IntegTest()` in
    the test case itself. So when writing the snapshot we have to take that
    same field into account.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    rix0rrr authored Jul 3, 2025
    Configuration menu
    Copy the full SHA
    cf35f57 View commit details
    Browse the repository at this point in the history
Loading