Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aws/aws-cdk-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: [email protected]
Choose a base ref
...
head repository: aws/aws-cdk-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: [email protected]
Choose a head ref
  • 9 commits
  • 78 files changed
  • 6 contributors

Commits on May 16, 2025

  1. feat(toolkit-lib): simplify action options (#503)

    Simplifies the options for various toolkit-lib actions by standardizing
    parameter structures and removing unnecessary complexity.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license.
    mrgrain authored May 16, 2025
    Configuration menu
    Copy the full SHA
    0137d34 View commit details
    Browse the repository at this point in the history
  2. chore: use AWS_MANAGED_KEY for integ tests (#499)

    Use an AWS-managed KMS key for bucket encryption in the bootstrapping of
    integ tests.
    
    This should shave ~1 minute off of the bootstrapping of every
    environment.
    
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    
    ---------
    
    Signed-off-by: github-actions <[email protected]>
    Co-authored-by: github-actions <[email protected]>
    rix0rrr and github-actions authored May 16, 2025
    Configuration menu
    Copy the full SHA
    b69d41f View commit details
    Browse the repository at this point in the history

Commits on May 19, 2025

  1. chore(deps): upgrade dependencies (#506)

    Upgrades project dependencies. See details in [workflow run].
    
    [Workflow Run]:
    https://github.com/aws/aws-cdk-cli/actions/runs/15101609071
    
    ------
    
    *Automatically created by projen via the "upgrade" workflow*
    
    ---------
    
    Signed-off-by: github-actions <[email protected]>
    Co-authored-by: github-actions <[email protected]>
    aws-cdk-automation and github-actions authored May 19, 2025
    Configuration menu
    Copy the full SHA
    a602917 View commit details
    Browse the repository at this point in the history
  2. fix(cdk-assets): indicate correct docker command that failed to execu…

    …te (#504)
    
    Users may override the executable used (instead of `docker`) by setting
    the CDK_DOCKER environment variable, but the message of the error thrown
    when such an executable does not exist was not similarly dynamic. Align
    the contents of the message with the executable invoked.
    
    Fixes #282.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    
    ---------
    
    Signed-off-by: Ian Kerins <[email protected]>
    Co-authored-by: Momo Kornher <[email protected]>
    isker and mrgrain authored May 19, 2025
    Configuration menu
    Copy the full SHA
    ea4ba36 View commit details
    Browse the repository at this point in the history
  3. chore(toolkit-lib): remove duplicate test helpers (#507)

    This PR removes duplicate test helper functions in the toolkit-lib
    package to improve code maintainability and reduce redundancy.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    mrgrain authored May 19, 2025
    Configuration menu
    Copy the full SHA
    d5f6f8c View commit details
    Browse the repository at this point in the history

Commits on May 20, 2025

  1. chore(toolkit-lib): unify IoHost helper (#512)

    Previously we had two different `IoHost` helpers for use in tests with
    slightly different functionality. I don't see a reason why this needs to
    be an either or, so I combined both helpers into one.
    
    Also gets rid of `RequireApproval` check in the `TestIoHost` and a
    corresponding test case. This test case was testing the implementation
    of `TestIoHost` only, which we obviously do not care about. With that
    change, we can also remove a leftover enum.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    mrgrain authored May 20, 2025
    Configuration menu
    Copy the full SHA
    1445ba1 View commit details
    Browse the repository at this point in the history
  2. fix(toolkit-lib): MFA token cannot be provided through IoHost (#508)

    Relates to #396 
    
    Considering this a bug fix, since it is currently not possible to
    integrate an IoHost with this. While this does affect the CLI, the DX is
    virtually unchanged. I run the auth test suite to ensure everything is
    still working as expected.
    
    Before:
    
    <img width="589" alt="before"
    src="https://github.com/user-attachments/assets/cb5d7d39-ed81-4bef-b859-3eb26d964f59"
    />
    
    After:
    
    <img width="619" alt="after"
    src="https://github.com/user-attachments/assets/bf410b53-44c5-4657-ab6b-890ca63fb508"
    />
    
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    mrgrain authored May 20, 2025
    Configuration menu
    Copy the full SHA
    d452163 View commit details
    Browse the repository at this point in the history
  3. fix(toolkit-lib): dependency constraints are too strict (#514)

    Due to a bug, we set constraints for dependency for other monorepo
    packages to "any future minor version" (i.e. `^1.2.3`) forcing consumers
    to always use latest packages with the toolkit-lib.
    
    What we wanted to do is constrain the use to "any minor version",
    including already published ones, i.e. `^1`.
    
    This change needed an upgrade of our projen Monorepo project type, which
    is also part of this PR. The API changed slightly here, hence the update
    of other values.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    mrgrain authored May 20, 2025
    Configuration menu
    Copy the full SHA
    33292d1 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2025

  1. refactor(toolkit-lib,cli): access default messages through IoHelper (#…

    …513)
    
    This change is in preparation of work to have all default message go
    through `IoHelper` instead of using `IO.DEFAULT_XYZ`. It contains a
    number of clean-up and alignment changes:
    
    - `IoDefaultMessages` is now a local-only class, that is only accessed
    through the new `IoHelper.defaults` getter.
    - Removed unused usage of `IoHelper` and `IoDefaultMessages` in
    `DiffFormatter`.
    - Changed every use of `IoDefaultMessages` to `IoHelper.defaults`
    - Made `IoDefaultMessages` methods async to be consistent with the rest,
    we can `void` at the place of use if we really need to
    - Also fixed most of the remaining `void`'ed call-sites for the above.
    Only the legacy logging is now left.
    - Removed unused `messages.ts` file
    - Removed unused `trace` from `logging.ts` (and respective test) to not
    encourage further use
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    mrgrain authored May 21, 2025
    Configuration menu
    Copy the full SHA
    6de56b2 View commit details
    Browse the repository at this point in the history
Loading