-
Notifications
You must be signed in to change notification settings - Fork 36
Comparing changes
Open a pull request
base repository: aws/aws-cdk-cli
base: [email protected]
head repository: aws/aws-cdk-cli
compare: [email protected]
- 14 commits
- 411 files changed
- 6 contributors
Commits on Apr 23, 2025
-
chore: ignore .lock files in the PR checker (#408)
Fixes # --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Configuration menu - View commit details
-
Copy full SHA for c7fafb2 - Browse repository at this point
Copy the full SHA c7fafb2View commit details -
chore: send Atmosphere log messages to test-specific log stream (#405)
--- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Configuration menu - View commit details
-
Copy full SHA for 1b1dd8d - Browse repository at this point
Copy the full SHA 1b1dd8dView commit details -
feat(cli-integ): speed up image pulls by logging into ECR public (#400)
Porting aws/aws-cdk-cli-testing#84 --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license Co-authored-by: Rico Hermans <[email protected]> Co-authored-by: Momo Kornher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fece7ec - Browse repository at this point
Copy the full SHA fece7ecView commit details
Commits on Apr 24, 2025
-
chore(cli-integ): add tests for refactor dry-run (#411)
--- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Configuration menu - View commit details
-
Copy full SHA for 840ad5a - Browse repository at this point
Copy the full SHA 840ad5aView commit details -
refactor(toolkit-lib): remove
requireApproval
option from diff (#372)`requireApproval` is deprecated and has been moved to the `CliIoHost`. this PR removes the last place where `requireApproval` was necessary in `tmp-toolkit-helpers`, in `formatSecurityDiff`. `formatSecurityDiff` now makes no _decisions_ on what to print; it returns the diff and a `permissionChangeType` for the `IoHost` to interpret. this is a slight behavior change, so all consumers of `formatSecurityDiff have been updated accordingly (`deploy` and `diff` in `toolkit-lib` and in the CLI). `requireApproval` is now a vestigial structure only in use in the CLI. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license --------- Co-authored-by: Momo Kornher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 86997d8 - Browse repository at this point
Copy the full SHA 86997d8View commit details
Commits on Apr 25, 2025
-
chore: add
CdkCliIntegTests
to this repo (#415)Now that the CLI tests are all run from the same repo, no need to have them separately anymore. Moving it together will make experimenting easier. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license --------- Signed-off-by: github-actions <[email protected]> Co-authored-by: github-actions <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f6bd7b9 - Browse repository at this point
Copy the full SHA f6bd7b9View commit details
Commits on Apr 28, 2025
-
chore: log integ test output to the file system (#416)
Write the (huge) text logs of integ test files to the file system if configured to do so (with `$INTEG_LOGS`), and use that feature in the GitHub logs to publish the logs as an artifact. At the same time, also start playing with Markdown reports of GitHub actions by writing to `$GITHUB_STEP_SUMMARY` to see what that looks like. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license --------- Signed-off-by: github-actions <[email protected]> Co-authored-by: github-actions <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c05e058 - Browse repository at this point
Copy the full SHA c05e058View commit details -
feat(cli-integ): optionally print memory usage on test start/finish (#…
…419) To be able to do (basic) memory analysis on different platforms when needed. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Configuration menu - View commit details
-
Copy full SHA for db9bf88 - Browse repository at this point
Copy the full SHA db9bf88View commit details
Commits on Apr 29, 2025
-
feat(refactor): support for stack filtering (#410)
Users can now pass the stacks they want to be considered for refactoring: cdk refactor StackA StackB ... The result will include any mapping that contains at least one of the selected stacks. If no pattern is passed, all stacks are considered. In this PR I also included the `refactor` command in the command line parsing list, which was missing. It was already working without it, but the command wouldn't show up in the help page, and it wouldn't recognize positional arguments. But the command itself (and its options) could be already used. Closes #363. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license --------- Co-authored-by: Kaizen Conroy <[email protected]> Co-authored-by: Momo Kornher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d2505cd - Browse repository at this point
Copy the full SHA d2505cdView commit details -
chore: shrinkwrap dependencies of @aws-cdk-testing/cli-integ (#414)
This is necessary for testing runs that run directly after a release of a web of packages that depend on each other using exact versions (notably, SDKv3). The problem occurs on all package managers, but is most notable when using CodeArtifact due to slow(er) replication latency, with an SLA of up to 30 minutes. If we run immediately after some new package versions have gotten released that depend on each other with precise versions , that some packages are available under the new versions, and some packages are not. This leads to an installation error in the tests. By using a shrinkwrap file, at least NPM users will be saved from this, because this will prevent the install from trying to use the just-released package. Instead it will use the tested combination from the shrinkwrap file. Revive the `@aws-cdk/yarn-cling` project that originally used to do this. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Configuration menu - View commit details
-
Copy full SHA for 8d91672 - Browse repository at this point
Copy the full SHA 8d91672View commit details -
chore: allow patch bumping again on CLI package (#409)
Remove the previous short-term fix to prevent major version bumps, and replace it with the version filtering mechanism introduced in projen. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license --------- Signed-off-by: github-actions <[email protected]> Co-authored-by: github-actions <[email protected]> Co-authored-by: Momo Kornher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f12ec97 - Browse repository at this point
Copy the full SHA f12ec97View commit details -
refactor(toolkit-lib): move code from tmp-toolkit-helpers (#424)
Move all code and tests from `tmp-toolkit-helpers` to `toolkit-lib`. Remove the now empty package. Made necessary changes to imports, config and tests. No functional code changes! --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license --------- Signed-off-by: github-actions <[email protected]> Co-authored-by: github-actions <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2093af0 - Browse repository at this point
Copy the full SHA 2093af0View commit details
Commits on Apr 30, 2025
-
chore: remove CDK_ASSETS version flag (#434)
Not needed anymore. No change to synth'd files. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Configuration menu - View commit details
-
Copy full SHA for ab559eb - Browse repository at this point
Copy the full SHA ab559ebView commit details -
chore:
yarn-cling
dependency is incorrectly set to*
(#433)This breaks the [release](https://github.com/aws/aws-cdk-cli/actions/runs/14752077174/job/41411691499): ```console > @aws-cdk-testing/cli-integ yarn run v1.22.22 warning package.json: "dependencies" has dependency "jest" with range "^29" that collides with a dependency in "devDependencies" of the same name with version "^29.7.0" warning package.json: "dependencies" has dependency "jest-junit" with range "^15" that collides with a dependency in "devDependencies" of the same name with version "^16" warning package.json: "dependencies" has dependency "ts-jest" with range "^29" that collides with a dependency in "devDependencies" of the same name with version "^29.2.5" $ npx projen unbump 👾 unbump | "/opt/hostedtoolcache/node/22.14.0/x64/bin/node" "/home/runner/work/aws-cdk-cli/aws-cdk-cli/node_modules/projen/lib/release/reset-version.task.js" 👾 unbump » gather-versions | node -e "require(require.resolve('cdklabs-projen-project-types/lib/yarn/gather-versions.exec.js')).cliMain()" @aws-cdk/yarn-cling=exact Updated versions { "name": "@aws-cdk-testing/cli-integ", "version": "0.0.0", "devDependencies": { "@aws-cdk/yarn-cling": "^0.0.0" } } Done in 4.24s. Done in 61.43s. 👾 release | git diff --ignore-space-at-eol --exit-code diff --git a/packages/@aws-cdk-testing/cli-integ/package.json b/packages/@aws-cdk-testing/cli-integ/package.json index f150439..8a1337a 100644 --- a/packages/@aws-cdk-testing/cli-integ/package.json +++ b/packages/@aws-cdk-testing/cli-integ/package.json @@ -39,7 +39,7 @@ "organization": true }, "devDependencies": { - "@aws-cdk/yarn-cling": "*", + "@aws-cdk/yarn-cling": "^0.0.0", "@cdklabs/eslint-plugin": "^1.3.2", "@stylistic/eslint-plugin": "^3", "@types/fs-extra": "^9", ``` --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Configuration menu - View commit details
-
Copy full SHA for 054afef - Browse repository at this point
Copy the full SHA 054afefView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff [email protected]@v2.1013.0