Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aws/aws-cdk-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: [email protected]
Choose a base ref
...
head repository: aws/aws-cdk-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: [email protected]
Choose a head ref
  • 9 commits
  • 79 files changed
  • 8 contributors

Commits on Mar 26, 2025

  1. chore(tmp-toolkit-helpers): formatStackDiff and `formatSecurityDiff…

    …` moved to tmp-toolkit-helpers (#278)
    
    moves two functions that are relevant to diff into
    `tmp-toolkit-helpers`. this will facilitate the adoption of `diff` in
    the programmatic toolkit as it will now be able to reuse these
    functions.
    
    existing tests pass to ensure no breakage. additional tests have been
    added to `tmp-toolkit-helpers` to test `formatXxxDiff`, which were
    previously not directly tested.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    
    ---------
    
    Signed-off-by: github-actions <[email protected]>
    Co-authored-by: github-actions <[email protected]>
    kaizencc and github-actions authored Mar 26, 2025
    Configuration menu
    Copy the full SHA
    0db3dc2 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2025

  1. refactor(toolkit): cxapp to use moden messaging infrastructure (#285)

    Refactors the `cxapp` api code to use modern messaging. This had a
    larger amount of knock-on effects then other refactors, to the PR is a
    bit bigger.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    
    ---------
    
    Signed-off-by: github-actions <[email protected]>
    Co-authored-by: github-actions <[email protected]>
    mrgrain and github-actions authored Mar 28, 2025
    Configuration menu
    Copy the full SHA
    2a9ee4c View commit details
    Browse the repository at this point in the history
  2. refactor(tmp-toolkit-helpers): DiffFormatter class (#283)

    the point of this PR is to refactor `formatStackDiff` and
    `formatSecurityDiff` into the same class. there's more to do to simplify
    these functions, but i'm making small refactors a priority.
    
    the achievement of this PR is to get rid of the giant laundry list of
    properties that go into each function in favor of a property bag, and to
    store the repeated properties within a class.
    
    this is tested by current unit tests -- as long as they still pass, this
    refactor should have not changed any functionality.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    
    ---------
    
    Signed-off-by: github-actions <[email protected]>
    Co-authored-by: github-actions <[email protected]>
    kaizencc and github-actions authored Mar 28, 2025
    Configuration menu
    Copy the full SHA
    f9f6d1d View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2025

  1. feat(toolkit-lib): diff (#279)

    introduces diff support for programmatic toolkit.
    
    - has feature parity with the existing CLI diff
    - programmatic toolkit functionality is unit tested.
    - AI disclosure: no AI
    
    does most of aws/aws-cdk#33182, but typed
    return will come later
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    
    ---------
    
    Signed-off-by: github-actions <[email protected]>
    Co-authored-by: github-actions <[email protected]>
    kaizencc and github-actions authored Mar 29, 2025
    Configuration menu
    Copy the full SHA
    cd35a1c View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2025

  1. chore: Fix URLs in md (#297)

    Fixes #296 
    
    This change is to fix URLs that return 404 errors.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    tacck authored Apr 1, 2025
    Configuration menu
    Copy the full SHA
    f816a1b View commit details
    Browse the repository at this point in the history
  2. feat(cli): CcApi context provider can be configured to fail if listin…

    …g does not find a specific count of resources (#251)
    
    Fixes #257
    
    As described in the issue, `CcApiContextProviderPlugin` should have the
    way to ensure the result has exact one resource.
    
    This PR adds the `expectedMatchCount` option to restrict the length of
    results in `listResources()`.
    
    Unit tests are added and modified ensure the changes.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    
    ---------
    
    Co-authored-by: Rico Huijbers <[email protected]>
    Tietew and rix0rrr authored Apr 1, 2025
    Configuration menu
    Copy the full SHA
    a1d5af9 View commit details
    Browse the repository at this point in the history
  3. chore(deps): upgrade dependencies (#298)

    Upgrades project dependencies. See details in [workflow run].
    
    [Workflow Run]:
    https://github.com/aws/aws-cdk-cli/actions/runs/14161479157
    
    ------
    
    *Automatically created by projen via the "upgrade" workflow*
    
    ---------
    
    Signed-off-by: github-actions <[email protected]>
    Co-authored-by: github-actions <[email protected]>
    Co-authored-by: Eli Polonsky <[email protected]>
    3 people authored Apr 1, 2025
    Configuration menu
    Copy the full SHA
    445fd71 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2025

  1. fix(toolkit): doesn't load on platforms without the Disposable API (#309

    )
    
    Toolkit classes reference the public static `Symbol.asyncDispose`
    symbol, but that is only defined on runtimes that are implementing the
    new Disposable API yet.
    
    On platforms that don't know that API, that constant doesn't exist and
    the class definition fails.
    
    Polyfill it.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    
    ---------
    
    Signed-off-by: github-actions <[email protected]>
    Co-authored-by: github-actions <[email protected]>
    rix0rrr and github-actions authored Apr 2, 2025
    Configuration menu
    Copy the full SHA
    20337de View commit details
    Browse the repository at this point in the history
  2. fix(cli): diff always prints stack name (#304)

    Fixes #302 
    
    In #264, we capture the output of
    the Formatter into a stream, and that is then converted to a string.
    This diff only gets printed if the diff isn't empty, but by some quirk
    `formatStackDiff` used to print the stack name _outside_ of the stream,
    thus creating the (correct) behavior. #264 made sure that `format`
    doesn't print, so we need to make sure that the consumer of
    `formatStackDiff` prints the relevant info.
    
    This PR makes sure that the stack name is returned as the formatted diff
    even if the actual diff is empty. We will print the right information
    when we print the formatted diff now.
    
    I also made similar modifications to `formatSecurityDiff`, as we should
    move away from `format` methods printing anything at all.
    
    BEFORE (cdk 2.1006.0):
    
    <img width="326" alt="Screenshot 2025-04-02 at 9 04 04 AM"
    src="https://github.com/user-attachments/assets/03b92517-e475-4c27-a4c1-52217be824c8"
    />
    
    
    AFTER (my local cdk):
    
    <img width="322" alt="Screenshot 2025-04-02 at 9 03 11 AM"
    src="https://github.com/user-attachments/assets/53a7d3e0-2e62-45ca-898b-93c923028346"
    />
    
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    
    ---------
    
    Signed-off-by: github-actions <[email protected]>
    Co-authored-by: github-actions <[email protected]>
    kaizencc and github-actions authored Apr 2, 2025
    Configuration menu
    Copy the full SHA
    d3f6c3c View commit details
    Browse the repository at this point in the history
Loading