-
Notifications
You must be signed in to change notification settings - Fork 35
Comparing changes
Open a pull request
base repository: aws/aws-cdk-cli
base: [email protected]
head repository: aws/aws-cdk-cli
compare: [email protected]
- 9 commits
- 79 files changed
- 8 contributors
Commits on Mar 26, 2025
-
chore(tmp-toolkit-helpers):
formatStackDiff
and `formatSecurityDiff……` moved to tmp-toolkit-helpers (#278) moves two functions that are relevant to diff into `tmp-toolkit-helpers`. this will facilitate the adoption of `diff` in the programmatic toolkit as it will now be able to reuse these functions. existing tests pass to ensure no breakage. additional tests have been added to `tmp-toolkit-helpers` to test `formatXxxDiff`, which were previously not directly tested. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license --------- Signed-off-by: github-actions <[email protected]> Co-authored-by: github-actions <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0db3dc2 - Browse repository at this point
Copy the full SHA 0db3dc2View commit details
Commits on Mar 28, 2025
-
refactor(toolkit): cxapp to use moden messaging infrastructure (#285)
Refactors the `cxapp` api code to use modern messaging. This had a larger amount of knock-on effects then other refactors, to the PR is a bit bigger. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license --------- Signed-off-by: github-actions <[email protected]> Co-authored-by: github-actions <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2a9ee4c - Browse repository at this point
Copy the full SHA 2a9ee4cView commit details -
refactor(tmp-toolkit-helpers): DiffFormatter class (#283)
the point of this PR is to refactor `formatStackDiff` and `formatSecurityDiff` into the same class. there's more to do to simplify these functions, but i'm making small refactors a priority. the achievement of this PR is to get rid of the giant laundry list of properties that go into each function in favor of a property bag, and to store the repeated properties within a class. this is tested by current unit tests -- as long as they still pass, this refactor should have not changed any functionality. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license --------- Signed-off-by: github-actions <[email protected]> Co-authored-by: github-actions <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f9f6d1d - Browse repository at this point
Copy the full SHA f9f6d1dView commit details
Commits on Mar 29, 2025
-
feat(toolkit-lib): diff (#279)
introduces diff support for programmatic toolkit. - has feature parity with the existing CLI diff - programmatic toolkit functionality is unit tested. - AI disclosure: no AI does most of aws/aws-cdk#33182, but typed return will come later --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license --------- Signed-off-by: github-actions <[email protected]> Co-authored-by: github-actions <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cd35a1c - Browse repository at this point
Copy the full SHA cd35a1cView commit details
Commits on Apr 1, 2025
-
Fixes #296 This change is to fix URLs that return 404 errors. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Configuration menu - View commit details
-
Copy full SHA for f816a1b - Browse repository at this point
Copy the full SHA f816a1bView commit details -
feat(cli): CcApi context provider can be configured to fail if listin…
…g does not find a specific count of resources (#251) Fixes #257 As described in the issue, `CcApiContextProviderPlugin` should have the way to ensure the result has exact one resource. This PR adds the `expectedMatchCount` option to restrict the length of results in `listResources()`. Unit tests are added and modified ensure the changes. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license --------- Co-authored-by: Rico Huijbers <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a1d5af9 - Browse repository at this point
Copy the full SHA a1d5af9View commit details -
chore(deps): upgrade dependencies (#298)
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/aws/aws-cdk-cli/actions/runs/14161479157 ------ *Automatically created by projen via the "upgrade" workflow* --------- Signed-off-by: github-actions <[email protected]> Co-authored-by: github-actions <[email protected]> Co-authored-by: Eli Polonsky <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 445fd71 - Browse repository at this point
Copy the full SHA 445fd71View commit details
Commits on Apr 2, 2025
-
fix(toolkit): doesn't load on platforms without the Disposable API (#309
) Toolkit classes reference the public static `Symbol.asyncDispose` symbol, but that is only defined on runtimes that are implementing the new Disposable API yet. On platforms that don't know that API, that constant doesn't exist and the class definition fails. Polyfill it. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license --------- Signed-off-by: github-actions <[email protected]> Co-authored-by: github-actions <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 20337de - Browse repository at this point
Copy the full SHA 20337deView commit details -
fix(cli): diff always prints stack name (#304)
Fixes #302 In #264, we capture the output of the Formatter into a stream, and that is then converted to a string. This diff only gets printed if the diff isn't empty, but by some quirk `formatStackDiff` used to print the stack name _outside_ of the stream, thus creating the (correct) behavior. #264 made sure that `format` doesn't print, so we need to make sure that the consumer of `formatStackDiff` prints the relevant info. This PR makes sure that the stack name is returned as the formatted diff even if the actual diff is empty. We will print the right information when we print the formatted diff now. I also made similar modifications to `formatSecurityDiff`, as we should move away from `format` methods printing anything at all. BEFORE (cdk 2.1006.0): <img width="326" alt="Screenshot 2025-04-02 at 9 04 04 AM" src="https://github.com/user-attachments/assets/03b92517-e475-4c27-a4c1-52217be824c8" /> AFTER (my local cdk): <img width="322" alt="Screenshot 2025-04-02 at 9 03 11 AM" src="https://github.com/user-attachments/assets/53a7d3e0-2e62-45ca-898b-93c923028346" /> --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license --------- Signed-off-by: github-actions <[email protected]> Co-authored-by: github-actions <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d3f6c3c - Browse repository at this point
Copy the full SHA d3f6c3cView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff [email protected]@v2.1007.0