Skip to content

Maintenance: delete examples in packages folder #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saragerion opened this issue Dec 16, 2021 · 5 comments · Fixed by #903
Closed

Maintenance: delete examples in packages folder #332

saragerion opened this issue Dec 16, 2021 · 5 comments · Fixed by #903
Assignees
Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Comments

@saragerion
Copy link
Contributor

saragerion commented Dec 16, 2021

Description of the feature request

Problem statement

Redundant examples in the logger folder.

Summary of the feature

The scope of this Issue is to delete this folder:
https://github.com/awslabs/aws-lambda-powertools-typescript/tree/main/packages/logger/examples
Nobody is using this folder, and it's just redundant at this point.

Code examples

Benefits for you and the wider AWS community

Describe alternatives you've considered

Additional context

Related issues, RFCs

@saragerion
Copy link
Contributor Author

Description TBD later

@dreamorosi dreamorosi added all documentation Improvements or additions to documentation labels Dec 23, 2021
@dreamorosi dreamorosi added this to the beta-release milestone Dec 23, 2021
@saragerion saragerion added the triage This item has not been triaged by a maintainer, please wait label Dec 28, 2021
@saragerion
Copy link
Contributor Author

As discussed today among the team, we will put this on hold to wait for developers' feedback on the usefulness of docs, examples in packages, global examples

@saragerion saragerion added the on-hold This item is on-hold and will be revisited in the future label Dec 28, 2021
@dreamorosi dreamorosi changed the title all: move all documented examples into the deployed examples Feature (examples): move all documented examples into the deployed examples May 12, 2022
@saragerion
Copy link
Contributor Author

Essentially the scope of this Issue is to delete this folder:
https://github.com/awslabs/aws-lambda-powertools-typescript/tree/main/packages/logger/examples
Nobody is using this folder, and it's just redundant at this point.

@saragerion saragerion removed the on-hold This item is on-hold and will be revisited in the future label May 16, 2022
@saragerion
Copy link
Contributor Author

TODO: edit link to those folders in all readmes and docs pages, example:
https://github.com/awslabs/aws-lambda-powertools-typescript#examples

@saragerion saragerion changed the title Feature (examples): move all documented examples into the deployed examples Feature (examples): delete examples in packages folder May 24, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi removed the triage This item has not been triaged by a maintainer, please wait label Oct 19, 2022
@dreamorosi dreamorosi changed the title Feature (examples): delete examples in packages folder Maintenance: delete examples in packages folder Nov 14, 2022
@dreamorosi dreamorosi added internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) completed This item is complete and has been merged/shipped labels Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants