-
Notifications
You must be signed in to change notification settings - Fork 441
docs(parser): fix a a typo in SqsEnvelope #7052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(parser): fix a a typo in SqsEnvelope #7052
Conversation
Signed-off-by: Dustin Alandzes <[email protected]>
Hey @DustinAlandzes thanks a lot for opening this PR to fix this typo! Can I ask you please to open an issue here: https://github.com/aws-powertools/powertools-lambda-python/issues/new?template=documentation_improvements.yml? Don't need to provide too much information, simples words are enough. Thanks. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7052 +/- ##
========================================
Coverage 96.26% 96.26%
========================================
Files 275 275
Lines 12917 12917
Branches 955 955
========================================
Hits 12435 12435
Misses 376 376
Partials 106 106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thanks for the quick reply! I made an issue for this here: #7053 Let me know if you need anything else |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @DustinAlandzes! Thanks a lot for working on this PR!
APPROVED!
e51b767
into
aws-powertools:develop
Issue number: #7053
Summary
There is a small spelling mistake in the docstring for SqsEnvelope.
Changes
npt -> not in a comment
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.