Skip to content

chore(ci): improve feature flags UA #7051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2025

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #6334

Summary

Changes

Fixes the user agent header for feature flags to use feature_flags instead of the generic parameters label when creating boto3 clients.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner July 28, 2025 17:25
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 28, 2025
@github-actions github-actions bot added the internal Maintenance changes label Jul 28, 2025
@leandrodamascena leandrodamascena self-assigned this Jul 28, 2025
Copy link

Copy link

codecov bot commented Jul 28, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.26%. Comparing base (d017744) to head (0904ff3).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...da_powertools/utilities/feature_flags/appconfig.py 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7051      +/-   ##
===========================================
- Coverage    96.27%   96.26%   -0.01%     
===========================================
  Files          275      275              
  Lines        12912    12917       +5     
  Branches       954      955       +1     
===========================================
+ Hits         12431    12435       +4     
  Misses         376      376              
- Partials       105      106       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leandrodamascena leandrodamascena merged commit 2cedb72 into develop Jul 28, 2025
12 of 14 checks passed
@leandrodamascena leandrodamascena deleted the feat/improve-ua-feature-flags branch July 28, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance changes size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Review the logic to add User Agent when working with feature flags
2 participants