-
Notifications
You must be signed in to change notification settings - Fork 464
docs(home): extract and fix examples #1113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changes: - Extract all code examples - Fix yaml, terraform and python - Add make file to format, lint and validate examples Related to - aws-powertools#1064 Fixed - aws-powertools#1067 - aws-powertools#1069
Codecov Report
@@ Coverage Diff @@
## develop #1113 +/- ##
========================================
Coverage 99.88% 99.88%
========================================
Files 119 119
Lines 5423 5423
Branches 618 618
========================================
Hits 5417 5417
Misses 2 2
Partials 4 4 Continue to review full report at Codecov.
|
|
@heitorlessa as per your request, i am breaking the larger PR #1065 into 16 smaller PRs. This one is the for |
HomePage code examplesHomePage code examples
HomePage code examples
Issue number:
Summary
Extract code examples from landing page and fix errors in python, yaml
Changes
Changes:
format,lint,compileandvalidateexamples to prevent errors from coming back1.26.11.26.1Bug fixes in this PR:
Lambda Layer - Terraformexample ( See issue Docs: HomePage - terraform example has a syntax error #1067 )An illegal target for a variable annotationin HomePage -SAR - CDKexamples ( See issue Docs: HomePage - Fix syntax errors in SAR CDK example #1206 )Example: Least-privileged IAM permissions to deploy Layerexample ( See issue Docs: HomePage - Least-privileged IAM permissions to deploy Layer has syntax errors #1207 )Terraform fix Changes:
awsprovider needs to be a newer version to support python3.9 runtimejsonencodeinstead of<<EOFto fix the formatting of the terraform snippetterraform fmtConfirmed terraform changes by:
terraform inittflintterraform planUser experience
Hosted version is here: https://gyft.github.io/aws-lambda-powertools-python/latest/
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.
View rendered docs/index.md