-
Notifications
You must be signed in to change notification settings - Fork 441
Closed
Labels
bugSomething isn't workingSomething isn't workingdocumentationImprovements or additions to documentationImprovements or additions to documentation
Description
Need to add proper ContextManager typing via typing.ContrxtManager in several places.
Currently overriding single_metric (-> ContextManager[SingleMetric]) and noticed several other areas where this needs done as well.
Also be nice if there was a proper DummySubSegment type returned for tracing provider.in_subsegment to avoid including types from aws modules to cast.
Expected Behavior
Have rich type annotations along for the ride when using context managers.
Current Behavior
Need to self annotate.
Possible Solution
Add in proper type annotation to some or all of the context manager decorated functions.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingdocumentationImprovements or additions to documentationImprovements or additions to documentation