Update rule E3049 to only trigger when host port is 0 (#3543)

Author: kddejong

src/cfnlint/rules/resources/ecs/ServiceDynamicPorts.py

@@ -172,12 +172,13 @@ def _filter_port_mappings(
                 if not isinstance(container_port, (str, int)):
                     continue
                 if str(port) == str(container_port):
-                    for _, host_part_validator in get_value_from_path(
+                    for host_port, host_part_validator in get_value_from_path(
                         container_port_validator,
                         port_mapping,
                         path=deque(["HostPort"]),
                     ):
-                        yield host_part_validator
+                        if str(host_port) == "0":
+                            yield host_part_validator
 
     def validate(
         self, validator: Validator, _: Any, instance: Any, schema: dict[str, Any]
@@ -212,4 +213,5 @@ def validate(
                             "has to have a 'HealthCheckPort' of 'traffic-port'",
                             path_override=health_check_port_validator.context.path.path,
                             validator=err_validator,
+                            rule=self,
                         )

test/unit/rules/resources/ecs/test_service_dynamic_ports.py

@@ -268,6 +268,7 @@ def rule():
                     path_override=deque(
                         ["Resources", "TargetGroup", "Properties", "HealthCheckPort"]
                     ),
+                    rule=ServiceDynamicPorts(),
                 )
             ],
         ),
@@ -330,6 +331,7 @@ def rule():
                     path_override=deque(
                         ["Resources", "TargetGroup", "Properties", "HealthCheckPort"]
                     ),
+                    rule=ServiceDynamicPorts(),
                 )
             ],
         ),
@@ -359,6 +361,7 @@ def rule():
                     path_override=deque(
                         ["Resources", "TargetGroup", "Properties", "HealthCheckPort"]
                     ),
+                    rule=ServiceDynamicPorts(),
                 )
             ],
         ),
@@ -552,6 +555,29 @@ def rule():
             deque(["Resources", "Service", "Properties"]),
             [],
         ),
+        (
+            {
+                "Resources": {
+                    "TaskDefinition": jsonpatch.apply_patch(
+                        dict(_task_definition),
+                        [
+                            {
+                                "op": "replace",
+                                "path": (
+                                    "/Properties/ContainerDefinitions/"
+                                    "0/PortMappings/0/HostPort"
+                                ),
+                                "value": "30",
+                            },
+                        ],
+                    ),
+                    "TargetGroup": dict(_target_group),
+                    "Service": dict(_service),
+                }
+            },
+            deque(["Resources", "Service", "Properties"]),
+            [],
+        ),
     ],
     indirect=["template"],
 )