Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

Conversation

manigandham
Copy link

Removed extra variables and organized both webpack config files to match as much as possible to make it easier to learn and compare differences.

Removed extra variables and organized both webpack config files to match as much as possible to make it easier to learn and compare differences.
@dnfclas
Copy link

dnfclas commented May 21, 2017

@manigandham,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla2.dotnetfoundation.org.

It will cover your contributions to all .NET Foundation-managed open source projects.
Thanks,
.NET Foundation Pull Request Bot

@dnfclas
Copy link

dnfclas commented May 22, 2017

@manigandham, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, .NET Foundation Pull Request Bot

@SteveSandersonMS
Copy link
Member

Thanks @manigandham for submitting this, and apologies for the slow response!

I think that sometime between when you submitted this and now, we must have refactored the Webpack configs already, because looking at the patterns across them all now, the proposed changes in this PR would no longer make the Vue template config consistent with the others. It seems that these changes would now make it less consistent with others, even if they are perfectly good changes on their own. The one thing that would still be applicable is removing the duplicated bundleOutputDir variable from the Vue template's webpack.config.js, which I'll do separately.

So again I apologise that my slow response has made this PR less applicable that it would originally have been. I'll mark it as closed, since things are now more consistent as they are anyway. Hope that's OK, and please continue to submit other PRs if you wish to contribute! Thanks.

@manigandham
Copy link
Author

No worries, thanks for the update.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants