Various fixes #113
Open
Various fixes #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were all suggested by build failures and warnings.
This is more consistent with standard presentation of settings. There's no need to call out the default value explicitly here – the default button in the dialog reveals it if needed. Instead, show the current value of the setting.
These are generated files, but I'm not sure how they are generated and wanted to ensure the build didn't crash in the meantime. Opened aricneto#112 to better document.
f28c3c3 to
da20e47
Compare
This adds a new menu item to the overflow button on the time dialog (from clicking on a solve in history) that switches to the main timer with that solve's scramble loaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #111
Before (with inspection time 20s):
After:
Fix for #108
Pretty straightforward I think? I think this covers the only two ways to exit the timer: inspection expiry and standard finish.
Added "Use scramble" feature for #97
I'm not really familiar with common Android architecture (intents/broadcasts/etc) but this seemed a rather neat way to do it. Feedback welcome.
Fix for #97
The history setting was being stored in an instance variable when changed, but not persisted back to the fragment arguments that are used when fragment is recreated (as happens in a rotation).
Before merging:
Usestring needs translations.