Tentative: Implemented binary output from fs_cat. #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ubi de feo <[email protected]>
Signed-off-by: ubi de feo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly a way to open a discussion about transferring files as binary from the board to the disk (and to a consumer such as Lab for MicroPython Editor.
I have initially implemented a
fs_cat_bytesmethod, but it does not belong to thepyboard.pyAPI.Of course the changes to
fs_catnow won't return text but an Array of numbers.This PR requires these changes to work, and they are both draft.
To make MicroPython.js consumer agnostic maybe it would make sense to have a way to
fs_catbytes and string as separate.Let's see how we can allow the editor/consumers to download binary files without corrupting them and still make MicroPython.js a clean module