-
-
Notifications
You must be signed in to change notification settings - Fork 469
Open
Labels
topic: codeRelated to content of the project itselfRelated to content of the project itselftype: imperfectionPerceived defect in any part of projectPerceived defect in any part of project
Description
Describe the problem
To reproduce
- Select File > Preferences... (or Arduino > Settings... for macOS users) from the Arduino IDE menus.
The "Preferences" dialog will open. - Select "Deutsch" from the "Language" menu.
ⓘ This language/locale was chosen arbitrarily for the demo. The fault occurs with all non-English locales. - Click the "OK" button.
The "Preferences" dialog will close. - Open the "Datei" ("File") menu.
🐛 The menu item label is "Save" instead of the localized "Speichern".
Expected behavior
All strings for which there is localization data are localized in the Arduino IDE UI.
Arduino IDE version
Original report
2.2.1 and 2.2.2-nightly-20230903
Last verified with
2.3.6
Operating system
Windows
Operating system version
Windows 10 x64
Additional context
Related
- fix missing i18n messages in IDE menu #2215
- Incomplete Dutch translation in menu bar #2616
- "Paste" menu item is not internationalized #2702
- Add missing translations #1431
- Missing translation in Theia's view-container context menu #1498
Additional reports
Keywords
-
localization
-
localized
-
l10n
-
internationalization
-
internationalized
-
i18n
-
translate
-
translation
-
translator
Issue checklist
- I searched for previous reports inI verified the problem still occurs when using the latestMy report contains all necessary detailsTo pick up a draggable item, press the space bar. While dragging, use the arrow keys to move the item. Press space again to drop the item in its new position, or press escape to cancel.
Metadata
Metadata
Assignees
Labels
topic: codeRelated to content of the project itselfRelated to content of the project itselftype: imperfectionPerceived defect in any part of projectPerceived defect in any part of project
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
[-]Missing translation for "save" in German[/-][+]Missing translation for "Save" in German[/+]per1234 commentedon Sep 3, 2023
Thanks for reporting this @Sinclair-ZX81.
I confirm that there was a regression in the localization of the File > Save menu item. I bisected the regression to 192aac5, where the language packs were bumped from 1.53.2 to 1.70.0.
The localization data key for the menu item is set here:
arduino-ide/arduino-ide-extension/src/browser/contributions/save-sketch.ts
Line 28 in 0f9f0d0
The data is here in version 1.53.2 of the language pack:
https://github.com/microsoft/vscode-loc/blob/295dfb35491adc41df4b89e0d839086131a34257/i18n/vscode-language-pack-de/translations/main.i18n.json#L5000
Without explanation of the reason for the breaking change, the data was moved in the language packs from
vs/workbench/contrib/files/browser/fileCommands/save
tovs/workbench/contrib/files/browser/fileConstants/save
by microsoft/vscode-loc@e36740c:https://github.com/microsoft/vscode-loc/blob/a51eba0bb6e14e9b26cb7b5fed1aeca520552010/i18n/vscode-language-pack-de/translations/main.i18n.json#L6189
And the key is also updated to
vs/workbench/contrib/files/browser/fileConstants/save
in the Theia package:https://github.com/eclipse-theia/theia/blob/v1.39.0/packages/core/src/common/i18n/nls.metadata.json#L9130-L9132
DanielFrantes commentedon Sep 7, 2023
DanielFrantes commentedon Sep 7, 2023
Sinclair-ZX81 commentedon Sep 7, 2023
[-]Missing translation for "Save" in German[/-][+]Missing translation for "Save"[/+]1.42.1
#2246ralf-krause commentedon Jun 27, 2024