Skip to content

Only the IP address is shown for unrecognized network boards #1331

Closed
@kittaakos

Description

@kittaakos

Describe the problem

This is the follow-up of #1327.

Arduino IDE 2.x shows only the IP address of connected but unrecognized boards. Before #1327, network boards not recognized by the Arduino CLI were not listed in the "Board Selector" menu. See the changes here and here.

#1327 will remove the above-mentioned filtering, and the Arduino IDE will show all network boards. Unfortunately, the IDE receives insufficient information from the CLI, so the IDE has no chance to show anything else but the IP.

Screen Shot 2022-08-17 at 14 41 58

Screen Shot 2022-08-17 at 14 41 40

Screen Shot 2022-08-17 at 14 41 23

The mdns-discovery is aware of these additional things; hence the Arduino IDE 1.x can enhance the label of an unrecognized network board:

HELLO "ciao" 1
{
  "eventType": "hello",
  "message": "Invalid HELLO command",
  "error": true
}
HELLO 1 "ciao"
{
  "eventType": "hello",
  "message": "OK",
  "protocolVersion": 1
}
START_SYNC
{
  "eventType": "start_sync",
  "message": "OK"
}
{
  "eventType": "add",
  "port": {
    "address": "10.0.1.25",
    "label": "esp32s2 at 10.0.1.25",
    "protocol": "network",
    "protocolLabel": "Network Port",
    "properties": {
      ".": "esp32s2usb",
      "auth_upload": "yes",
      "board": "esp32s2usb",
      "hostname": "esp32s2.local.",
      "port": "3232",
      "ssh_upload": "no",
      "tcp_check": "no"
    }
  }
}

The same information is missing from the Arduino CLI board watch (board list -w --format json):

{
  "type": "add",
  "address": "/dev/cu.usbmodem03",
  "protocol": "serial",
  "protocol_label": "Serial Port (USB)"
}
{
  "type": "add",
  "address": "10.0.1.25",
  "protocol": "network",
  "protocol_label": "Network Port"
}

So the IDE fails to show esp32s2 at 10.0.1.25 and falls back to Unknown 10.0.1.25.

To reproduce

The simplest way is to try it with Arduino CLI:

./arduino-cli board list -w --format json

Expected behavior

Arduino IDE should receive the properties from the CLI discovered by the mdns-discovery.

{
    "properties": {
      ".": "esp32s2usb",
      "auth_upload": "yes",
      "board": "esp32s2usb",
      "hostname": "esp32s2.local.",
      "port": "3232",
      "ssh_upload": "no",
      "tcp_check": "no"
    }
}

Or the IDE should receive the "label": "esp32s2 at 10.0.1.25", from the CLI.

Arduino IDE version

9e2b73a

Operating system

macOS

Operating system version

12.3.1

Additional context

Related (if not the same): #567

Issue checklist

  • I searched for previous reports in
    I verified the problem still occurs when using the latest
    My report contains all necessary details

Activity

added
topic: codeRelated to content of the project itself
type: imperfectionPerceived defect in any part of project
topic: CLIRelated to Arduino CLI
on Aug 17, 2022
self-assigned this
on Aug 17, 2022
kittaakos

kittaakos commented on Aug 17, 2022

@kittaakos
ContributorAuthor

Expected behavior

IDE should receive the properties from the CLI

Looks like the IDE needs the properties. See here #740 (comment)

kittaakos

kittaakos commented on Aug 18, 2022

@kittaakos
ContributorAuthor

IDE should receive the properties

It's all available 🤦 So the CLI does not block this task.

kittaakos

kittaakos commented on Aug 18, 2022

@kittaakos
ContributorAuthor

There is one issue: the mdns-discovery response has the expected label: "label": "esp32s2 at 10.0.1.25". The CLI does not provide the desired label. Only the properties and the properties does not contain the label the IDE (1.x) users got used to.

{
  "properties": {
      ".": "esp32s2usb",
      "auth_upload": "yes",
      "board": "esp32s2usb",
      "hostname": "esp32s2.local.",
      "port": "3232",
      "ssh_upload": "no",
      "tcp_check": "no"
    }
}
added a commit that references this issue on Aug 18, 2022
changed the title [-]IDE2 must show more than the IP address of unrecognized network boards[/-] [+]Only the IP address is shown for unrecognized network boards[/+] on Aug 19, 2022
added 2 commits that reference this issue on Aug 23, 2022
6cae53b
a699f4c

9 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

conclusion: resolvedIssue was resolvedtopic: CLIRelated to Arduino CLItopic: codeRelated to content of the project itselftype: imperfectionPerceived defect in any part of project

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Participants

    @kittaakos@per1234@MarkSDS

    Issue actions

      Only the IP address is shown for unrecognized network boards · Issue #1331 · arduino/arduino-ide