Check the folder content in new version of the agent on macos #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #797 +/- ##
==========================================
- Coverage 11.00% 10.96% -0.05%
==========================================
Files 55 55
Lines 4052 4068 +16
==========================================
Hits 446 446
- Misses 3551 3567 +16
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
test release: |
cmaglie
requested changes
Jun 8, 2023
also set prerelease: true for the github release, so that we can perform tests
This reverts commit 61373da.
cmaglie
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
bug fix
when uninstalling an old version of the agent (e.g. 1.2.7) a folder in
~/Applications/ArduinoCreateAgentcould be left behind (empty, but existing), after uninstalling.This will trigger this error when running a new agent:
The check in the new agent is performed on the existence of the
ArduinoCreateAgent.appsubfolder.no
Partially fixes #795