Skip to content

Conversation

iabdalkader
Copy link
Contributor

No description provided.

Copy link
Member

@facchinm facchinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'd just add a comment stating the the "downstream" platforms should add a define (eg. SPI_HAS_PERIPHERAL_MODE) in case they support the functionality

@iabdalkader
Copy link
Contributor Author

add a comment stating the the "downstream" platforms should add a define (eg. SPI_HAS_PERIPHERAL_MODE) in case they support the functionality

Updated.

SPI_MODE3 = 3,
} SPIMode;

// Platforms should add a define (eg. SPI_HAS_PERIPHERAL_MODE) if they
Copy link
Member

@facchinm facchinm Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the eg to make the define official :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@facchinm facchinm merged commit a07b034 into arduino:master Sep 29, 2025
2 of 3 checks passed
@iabdalkader iabdalkader deleted the spi_bus_mode branch September 29, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants