Adding async capability to database seeding operations #734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks |
|
The FunctionalTests project does not build with these changes, because the Contributor1 and Contributor2 properties @samanazadi1996 removed are used by the unit tests. Also the CustomWebApplicationFactory uses PopulateTestData in a synchronous override. Please revert or fix the Tests. |
|
Test errors were fixed in the new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, the Initialize and PopulateTestData methods in the SeedData class have been modified to be async. Additionally, the SeedDatabase method has been converted to an async method. These changes improve the performance and responsiveness of the application by allowing database seeding operations to be performed asynchronously, enhancing the overall program efficiency.