fix: broken import cz default #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkrzyzanek
reviewed
May 19, 2025
| @@ -27,10 +27,10 @@ def parse_subject(text): | |||
|
|
|||
|
|
|||
| class GithubJiraConventionalCz(BaseCommitizen): | |||
| bump_pattern = defaults.bump_pattern | |||
| bump_map = defaults.bump_map | |||
| bump_pattern = defaults.BUMP_PATTERN | |||
There was a problem hiding this comment.
When it's a breaking change and backward compatibility is not provided I think it's necessary to properly set the dependency on the right version of commitizen in setup.py
https://github.com/apheris/cz-github-jira-conventional/blob/main/setup.py#L18
There was a problem hiding this comment.
I just fixed it in the latest iteration.
74e44f7 to
6abfc8f
Compare
|
Thank you so much. I'll try to create a new release in a timely manner, but I might need a few days. |
falko-apheris
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related commitizen issue: commitizen-tools/commitizen#1435