Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getter for private fields to Concat, Conjoin, SplitGlobal/Local Step #2687

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

rdtr
Copy link
Contributor

@rdtr rdtr commented Jul 16, 2024

No description provided.

@Cole-Greer
Copy link
Contributor

Thanks Norio, LGTM, VOTE +1

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 76.72%. Comparing base (9b46b67) to head (f272b6f).
Report is 167 commits behind head on 3.7-dev.

Files Patch % Lines
...gremlin/process/traversal/step/map/ConcatStep.java 0.00% 2 Missing ⚠️
...remlin/process/traversal/step/map/ConjoinStep.java 0.00% 1 Missing ⚠️
...in/process/traversal/step/map/SplitGlobalStep.java 0.00% 1 Missing ⚠️
...lin/process/traversal/step/map/SplitLocalStep.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             3.7-dev    #2687      +/-   ##
=============================================
+ Coverage      76.14%   76.72%   +0.57%     
- Complexity     13152    13187      +35     
=============================================
  Files           1084     1087       +3     
  Lines          65160    66382    +1222     
  Branches        7285     7300      +15     
=============================================
+ Hits           49616    50929    +1313     
+ Misses         12839    12742      -97     
- Partials        2705     2711       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiazcy
Copy link
Contributor

xiazcy commented Jul 16, 2024

VOTE +1

@rdtr
Copy link
Contributor Author

rdtr commented Jul 17, 2024

Please merge it if there is no concern. Thanks !

@kenhuuu
Copy link
Contributor

kenhuuu commented Jul 17, 2024

VOTE +1.

@xiazcy xiazcy merged commit 812bc1d into apache:3.7-dev Jul 17, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants