[TINKERPOP-3082] Allow specifying a customized Spark AppName #2634
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.7-dev #2634 +/- ##
=============================================
+ Coverage 76.14% 76.77% +0.62%
- Complexity 13152 13189 +37
=============================================
Files 1084 1087 +3
Lines 65160 66324 +1164
Branches 7285 7293 +8
=============================================
+ Hits 49616 50917 +1301
+ Misses 12839 12693 -146
- Partials 2705 2714 +9 ☔ View full report in Codecov by Sentry. |
spark-gremlin/src/main/java/org/apache/tinkerpop/gremlin/spark/structure/Spark.java
Outdated
Show resolved
Hide resolved
spark-gremlin/src/test/java/org/apache/tinkerpop/gremlin/spark/structure/SparkTest.java
Show resolved
Hide resolved
spark-gremlin/src/test/java/org/apache/tinkerpop/gremlin/spark/structure/SparkTest.java
Show resolved
Hide resolved
|
Could you also please add a short note to the CHANGELOG? |
|
VOTE +1 pending minor fixes. |
819da69
to
3178e26
Compare
|
VOTE+1 |
|
Thanks @ministat, LGTM |
CHANGELOG.asciidoc
Outdated
| @@ -64,6 +64,7 @@ This release also includes changes from <<release-3-6-7, 3.6.7>>. | |||
| * TINKERPOP-3021 Publish ARM64 Gremlin Console Images | |||
| * TINKERPOP-3030 Update to .NET 8 | |||
| * TINKERPOP-3068 Make serviceName and mergedParams public for provider usage in CallStep | |||
| * TINKERPOP-3082 Allow specifying a customized Spark app name | |||
There was a problem hiding this comment.
Sorry, I should have been more specific. Please remove this and add something like Allow specifying a customized Spark app name to https://github.com/apache/tinkerpop/blob/3.7-dev/CHANGELOG.asciidoc?plain=1#L30
This "Improvements" section is automatically generated during release so it shouldn't be manually modified.
|
Sorry again for not being clear about where to add the CHANGELOG entry. After you move that line, I will merge this PR. |
3178e26
to
42a4458
Compare
|
I have moved the description to the place you suggested. Please help verify it. |
Yes, this is correct location, but it appears another change was committed to 3.7-dev to the CHANGELOG that caused a minor merge conflict in your PR. Do you mind updating this again? |
It should allow override the Spark App name if user wants to. If user does not specify the Spark app name, we can provide the default one.
42a4458
to
194d684
Compare
|
The conflict was fixed. |
It should allow overriding the Spark App name if user wants to. If user does not specify the Spark app name, we will provide the default one. This is useful for user to see different Spark App if there are many Gremlin Servers sharing the same Spark cluster.