Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

GitHub Issue #15856 -- Fix query portion parsing when not in html5 mode. #15857

Closed
wants to merge 1 commit into from

Conversation

ed-at-work
Copy link

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix for issue #15856

What is the current behavior? (You can also link to an open issue here)
Issue #15856

What is the new behavior (if this is a feature change)?
The query portion of the URL is appended to the parsed path once the fragment identifier has been removed. This occurs for the non-html5 mode.

Does this PR introduce a breaking change?
Not that I can tell.

Please check if the PR fulfills these requirements

Other information:

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ed-at-work
Copy link
Author

I signed it.

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@ed-at-work
Copy link
Author

Realized that this doesn't work quite as expected when there is a query portion after the fragment. Unfortunately that's not a valid URL but angular seems to expect it. I'm going to tweak it for that scenario as well and provide tests as well.

@ed-at-work ed-at-work deleted the issue-#15856 branch March 26, 2017 08:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants