-
Notifications
You must be signed in to change notification settings - Fork 877
[WIP] docs(testing): new chapter, new samples #2198
Conversation
a790880
to
12c67c6
Compare
1622aac
to
adf52e9
Compare
7b35764
to
5fd3c4d
Compare
9526756
to
78b29ff
Compare
:marked | ||
# Introduction to Angular Testing | ||
|
||
You write tests to explore and confirm the behavior of parts of our application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/our/your?
|
In a lot of places where you say "test class" when discussing what the TestBed creates, I think it would be clearer to say "test component". Ward sez: Great idea. Fixed |
In the Ward sez: I am conflicted about this. I deliberately left out all import statements so that people can focus on the code and the ideas. I feel this is OK because the full code is readily available in the plunkers. I could be persuaded to change my mind. But including all the imports will often almost double the example size and I'm not keen on that. Thinking. |
EDIT: nevermind, I see the follow-up commentary. |
1. Test it as a stand-alone component | ||
1. Test it as used by a substitute for `DashboardHeroComponent` | ||
|
||
A quick look at the `DashboardHeroComponent` constructor discourages the first approach: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DashboardComponent
@Foxandxss and @juliemr Thanks for your feedback. I believe I have incorporated all of it. My only point of disagreement is about whether to show As I explained above, I am reluctant to do so because I feel that it distracts from the code. Someone who wants to know where those thing actually come from can see that in a heartbeat by looking at the full code in the plunker. I don't know that I'm "right" about this choice. I can only say that I think I have a good reason. Let's see what our audience thinks. Thanks so much! p.s.: I know this is incomplete. I have many more sections to go. I hope it is a good enough start. |
b06a892
to
a89ecf7
Compare
One more comment - this implies that |
Other than that, this looks like a great start to me! |
e633c67
to
a7c1248
Compare
a7c1248
to
8a03ad3
Compare
WIP Do not merge
Totally revised testing chapter for RC5 and beyond.