fix(@angular/build): support Vite allowedHosts option for development server
#29466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7e3c147 to
7db8e28
Compare
dgp1130
approved these changes
Jan 23, 2025
| * @param options An options object. | ||
| * @returns | ||
| */ | ||
| export async function executeOnceAndGet<T>( |
There was a problem hiding this comment.
Consider: Would it be worth sharing the "executeOnce" part of these two functions and refactoring that into a shared utility so the major difference is the fetch vs. http part? This way future changes don't risk diverging the two.
…nt server Vite version 6.0.9+, which is now used by the Angular CLI, contains a potentially breaking change for some development setups. Examples of such setups include those that use reverse proxies or custom host names during development. The change within a patch release was made by Vite to address a security vulnerability. For projects that directly access the development server via `localhost`, no changes should be needed. However, some development setups may now need to adjust the newly introduced `allowedHosts` development server option. This option can include an array of host names that are allowed to communicate with the development server. The option sets the corresponding Vite option within the Angular CLI. For more information on the option and its specific behavior, please see the Vite documentation located here: https://vite.dev/config/server-options.html#server-allowedhosts The following is an example of the configuration option allowing `example.com`: ``` "serve": { "builder": "@angular/build:dev-server", "options": { "allowedHosts": ["example.com"] }, ``` Additional details on the vulnerability can be found here: GHSA-vg6x-rcgg-rjx6
7db8e28 to
c2f1d35
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vite version 6.0.9+, which is now used by the Angular CLI, contains a potentially breaking change for some development setups. Examples of such setups include those that use reverse proxies or custom host names during development. The change within a patch release was made by Vite to address a security vulnerability. For projects that directly access the development server via
localhost, no changes should be needed. However, some development setups may now need to adjust the newly introducedallowedHostsdevelopment server option. This option can include an array of host names that are allowed to communicate with the development server. The option sets the corresponding Vite option within the Angular CLI. For more information on the option and its specific behavior, please see the Vite documentation located here:https://vite.dev/config/server-options.html#server-allowedhosts
The following is an example of the configuration option allowing
example.com:Additional details on the vulnerability can be found here: GHSA-vg6x-rcgg-rjx6