Skip to content

fix(@angular-devkit/build-angular): compile schema in synchronously #20850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2021
Merged

fix(@angular-devkit/build-angular): compile schema in synchronously #20850

merged 1 commit into from
May 19, 2021

Conversation

alan-agius4
Copy link
Collaborator

AJV only support a single schema with the same ID, compiling schemas async can cause a race condition were multiple schemas with the same name as compiled at the same time.

Closes #20847

AJV only support a single schema with the same ID, compiling schemas async can cause a race condition were multiple schemas with the same name as compiled at the same time.

Closes #20847
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label May 19, 2021
@alan-agius4 alan-agius4 requested a review from clydin May 19, 2021 13:51
@google-cla google-cla bot added the cla: yes label May 19, 2021
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label May 19, 2021
@alan-agius4 alan-agius4 merged commit 43926a2 into angular:master May 19, 2021
@alan-agius4 alan-agius4 deleted the use-compile-sync branch May 19, 2021 14:34
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: schema with key or id "BuilderProgressSchema" already exists
2 participants