fix(@angular-devkit/build-angular): fixed ignoring of karma plugins config #19994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5f5151a to
60bc0cc
Compare
alan-agius4
reviewed
Feb 8, 2021
packages/angular_devkit/build_angular/src/webpack/plugins/karma/karma.ts
Show resolved
Hide resolved
alan-agius4
requested changes
Feb 8, 2021
Collaborator
alan-agius4
left a comment
There was a problem hiding this comment.
Thanks for your contribution.
See below.
…onfig
Previously `karma-coverage` was validated only when in karma plugins config one of these was added
``'karma-coverage'` or `require('karma-coverage')`
This change will allow cli to validate `karma-coverage` plugin if in `karma.conf.js` `'karma-*'` is used. Example:
```
plugins: [
...
'karma-*',
require('@angular-devkit/build-angular/plugins/karma'),
...
]
```
Fixes angular#19993
60bc0cc to
7434f5d
Compare
alan-agius4
approved these changes
Feb 8, 2021
Collaborator
alan-agius4
left a comment
There was a problem hiding this comment.
Thanks once again for your contribution. LGTM
Contributor
Author
Glad to contribute 😃 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In angular 11 Previously
karma-coveragewas validated only when in karma plugins config one of these was added``'karma-coverage'
orrequire('karma-coverage')`This change will allow cli to validate
karma-coverageplugin if inkarma.conf.js'karma-*'is used. Example:Fixes #19993