Skip to content

Commit 8e981d0

Browse files
alan-agius4filipesilva
authored andcommitted
feat(@angular-devkit/core): add handling for defaultConfiguration target definition property
1 parent 1da359a commit 8e981d0

File tree

4 files changed

+7
-2
lines changed

4 files changed

+7
-2
lines changed

etc/api/angular_devkit/core/src/_golden-api.d.ts

+1
Original file line numberDiff line numberDiff line change
@@ -978,6 +978,7 @@ export declare class SynchronousDelegateExpectedException extends BaseException
978978
export interface TargetDefinition {
979979
builder: string;
980980
configurations?: Record<string, Record<string, JsonValue | undefined> | undefined>;
981+
defaultConfiguration?: string;
981982
options?: Record<string, JsonValue | undefined>;
982983
}
983984

packages/angular_devkit/core/src/workspace/definitions.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export interface ProjectDefinition {
2525
export interface TargetDefinition {
2626
options?: Record<string, JsonValue | undefined>;
2727
configurations?: Record<string, Record<string, JsonValue | undefined> | undefined>;
28-
28+
defaultConfiguration?: string;
2929
builder: string;
3030
}
3131

@@ -234,6 +234,7 @@ export class TargetDefinitionCollection extends DefinitionCollection<TargetDefin
234234
builder: definition.builder,
235235
options: definition.options,
236236
configurations: definition.configurations,
237+
defaultConfiguration: definition.defaultConfiguration,
237238
};
238239

239240
super.set(definition.name, target);

packages/angular_devkit/core/src/workspace/json/reader.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ function parseTargetsObject(
294294
const name = key.value;
295295
if (context.trackChanges) {
296296
targets[name] = createVirtualAstObject<TargetDefinition>(value, {
297-
include: [ 'builder', 'options', 'configurations' ],
297+
include: [ 'builder', 'options', 'configurations', 'defaultConfiguration' ],
298298
listener(op, path, node, value) {
299299
jsonMetadata.addChange(
300300
op,

packages/angular_devkit/core/src/workspace/json/writer.ts

+3
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,9 @@ function convertJsonTarget(target: TargetDefinition): JsonObject {
104104
...(isEmpty(target.configurations)
105105
? {}
106106
: { configurations: target.configurations as JsonObject }),
107+
...(target.defaultConfiguration === undefined
108+
? {}
109+
: { defaultConfiguration: target.defaultConfiguration }),
107110
};
108111
}
109112

0 commit comments

Comments
 (0)