Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Fix for sizing bug introduced by #718 #735

Merged
merged 1 commit into from
Mar 9, 2015

Conversation

cmlenz
Copy link
Contributor

@cmlenz cmlenz commented Mar 9, 2015

The search input size was being calculated incorrectly for non-multiple select instances using the Bootstrap theme. Remedy by only calling the sizing function when the select is in multi mode, which is how this function is guarded on other call sites as well.

Check out the Bootstrap select field on the demo.html page to see the problem in action.

…s being calculated incorrectly for non-multiple select instances using the Bootstrap theme. Remedy by only calling the sizing function when the select is in multi mode, which is how this function is guarded on other call sites as well.
dimirc added a commit that referenced this pull request Mar 9, 2015
Fix for sizing bug introduced by #718
@dimirc dimirc merged commit 27c565e into angular-ui:master Mar 9, 2015
@dimirc
Copy link
Contributor

dimirc commented Mar 9, 2015

v0.11.1 released

@cmlenz
Copy link
Contributor Author

cmlenz commented Mar 9, 2015

Wow that was quick. Thanks!

@igorlino
Copy link

Using the latest version (0.11.1) from UI-Select shows a search input size problem. When opening for the 1st time, it takes the style="width:21px"
only after click over the icon, goes to a normal width, filling the dialog. (but again, using some magical number). I find strange a component needs magical numbers at that granular level, perhaps if it would be a container, but definitively not an input.

Following workaround code fixes for me at the moment:
.select2-search > .ui-select-search.select2-input {
width: 100% !important;
}

@cmlenz
Copy link
Contributor Author

cmlenz commented Mar 10, 2015

@igorlino can you provide an example where this can be reproduced?

@igorlino
Copy link

@cmlenz that's a bit hard, I use ui-select in several places with different model bindings. I'm using the very latest versions. "bootstrap": "~3.3.2", "angular-ui-bootstrap-bower": "~0.12.1", "angular-ui-select": "~0.11.1", "select2-bootstrap-css": "~1.4.6".

The this sizing problem appeared only after 0.11.0. If I revert back the previous version, the problem is gone.

@cmlenz cmlenz deleted the fix-sizing-single branch March 10, 2015 15:30
@cmlenz
Copy link
Contributor Author

cmlenz commented Mar 10, 2015

@igorlino I'd really need a Plunk or something where the problem is reproducible. I've tried quite a few different scenarios and they've all worked for me. Also, what browsers are you seeing this on?

@igorlino
Copy link

@cmlenz I understand, I will see what can I do to reproduce it, its bit of a problem since i'm under time pressure for other reasons. The browser is Version 40.0.2214.115 m

@dimirc
Copy link
Contributor

dimirc commented Mar 11, 2015

FYI release v0.11.1 look like it was pointing to incorrect commit (#742)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants