Skip to content

Too small buffer size, too big viewport problem #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dhilt opened this issue Jul 16, 2017 · 4 comments
Closed

Too small buffer size, too big viewport problem #171

dhilt opened this issue Jul 16, 2017 · 4 comments

Comments

@dhilt
Copy link
Member

dhilt commented Jul 16, 2017

Some kind of race condition occures when the viewport is big enough while the "buffer-size" is small enough. Look at the demo! Scroller tries to break through the top border of the viewport. 5 times it loads data packs (of 3 items, per "buffer-size" = 3) and scroll position does not change, it stays at the very bottom, while should move up per each iteration.

rec001

@dhilt
Copy link
Member Author

dhilt commented Jul 17, 2017

Workaround: play with "buffer-size", "padding" and the viewport height.

@misterdev
Copy link
Contributor

I've played a lot with butter-size and padding but it didn't work for me. The only thing that solves it in my app is to give every item a fixed size in CSS. Using computed values like ng-style doesn't seem to work.

@dhilt
Copy link
Member Author

dhilt commented Aug 31, 2017

@misterdev The problem has been fixed in effective-height branch and it will be included in the next release. The branch' distributive is also available: https://raw.githubusercontent.com/angular-ui/ui-scroll/effective-height/dist/ui-scroll.js.

@dhilt
Copy link
Member Author

dhilt commented Sep 29, 2017

The fix is in 1.7.0-rc.2 published version.

@dhilt dhilt closed this as completed Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants