Skip to content

Laravel 8 support #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2020
Merged

Laravel 8 support #76

merged 2 commits into from
Sep 17, 2020

Conversation

UpwardProcess
Copy link
Contributor

Laravel 8 support.

Possible Laravel 8 support.
@UpwardProcess
Copy link
Contributor Author

Pinging @andywer (based on your own comment on a previous PR).

composer.json Outdated
@@ -30,7 +30,7 @@
},
"extra": {
"component": "package",
"frameworks": ["Laravel 7"]
"frameworks": ["Laravel 8"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works with Laravel 8 out-of-the-box and still works with Laravel 7, then let's make it "frameworks": ["Laravel 7", "Laravel 8"], shall we? 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @andywer, updated in the latest commit.

@andywer
Copy link
Owner

andywer commented Sep 16, 2020

Thanks for the PR, @UpwardProcess!

I left one question for you.

Update suggested by andywer.
@andywer andywer merged commit 7f6868c into andywer:laravel-6 Sep 17, 2020
andywer added a commit that referenced this pull request Sep 25, 2020
stefanschindler added a commit to CampaigningSoftware/laravel-js-localization that referenced this pull request Jan 23, 2025
* Update composer.json

Possible Laravel 8 support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants