Skip to content

Allow non-string values as translation parameters in Lang.get #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2018
Merged

Allow non-string values as translation parameters in Lang.get #53

merged 1 commit into from
May 13, 2018

Conversation

UpwardProcess
Copy link
Contributor

@UpwardProcess UpwardProcess commented May 13, 2018

This fixes broken usages similar to this: Lang.get('general.number_of_rows', {number: 10})

I have updated the minified file at public/js/localization.min.js manually as it was just a minor change.

References #52

@andywer
Copy link
Owner

andywer commented May 13, 2018

Thanks, @UpwardProcess! 😊

@andywer andywer merged commit cdba041 into andywer:laravel-5 May 13, 2018
stefanschindler added a commit to CampaigningSoftware/laravel-js-localization that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants